Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ability to install rocks for which there exists only a .src.rock entry in the manifest #295

Open
mrcjkb opened this issue Dec 31, 2024 · 0 comments

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Dec 31, 2024

In #291, if there is no rockspec entry, but there is a src.rock entry in the manifest, rocks will try to install from the rockspec's source first, falling back to fetching the src.rock if the rockspec.source can't be fetched.

This is fine, but it has one edge case: If the rockspec source can be fetched, the lockfile is populated with the rockspec.source hash and not the .src.rock hash. To be able to fetch the rockspec from the src.rock, in a pure manner, nix will need to know the hash of the .src.rock.

To solve this, we should:

  • Split build into separate pub(crate) fetch_source and build steps (we can still expose the current build function).
  • Build using the src.rock if no rockspec entry exists in the manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant