feat: factory enhancements #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakrad
suggested changes
Dec 29, 2024
src/StableAssetFactory.sol
Outdated
| address public lpTokenBeacon; | ||
|
|
||
| /** | ||
| * @dev Beacon for the LPToken implementation. |
src/StableAssetFactory.sol
Outdated
| function createPoolConstantExchangeRate(CreatePoolArgument calldata argument) public { | ||
| createPool(argument, constantExchangeRateProvider); | ||
| } | ||
| stableAsset.proposeGovernance(governance); |
There was a problem hiding this comment.
does it mean governance should accept the ownership always in 2 step?
feat: demo deployment
feat: tests coverage and oz upgrade
feat: net spec
feat: renaming contracts and vars
feat: uups upgrades
feat: convert WLPToken to ERC4626 standard
feat: added support for exchange rate provider for both tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.