Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve response via ack for sync and sync-serve #2308

Closed
Tracked by #2244
vigith opened this issue Jan 3, 2025 · 1 comment
Closed
Tracked by #2244

serve response via ack for sync and sync-serve #2308

vigith opened this issue Jan 3, 2025 · 1 comment
Assignees

Comments

@vigith
Copy link
Member

vigith commented Jan 3, 2025

No description provided.

@BulkBeing
Copy link
Contributor

I don't think we need to handle the /sync* endpoints specially here, since the callback state works as a tracker for these requests

if let Err(e) = notify.await {

The handlers will only send response back to the client when it receives all callbacks.

The confirm_save channel which is used to confirm that the message has been saved successfully to ISB in the previous PR:

  • Return success response to client in /async endpoint
  • Return early failure message to client /sync* endpoints if saving payload to ISB fails. Else, the handler waits till it receives callbacks from all vertices.

@yhl25 yhl25 closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants