From 14929ead045c5a68d5c32e5d014d92e410494c30 Mon Sep 17 00:00:00 2001 From: Sreekanth Date: Fri, 20 Sep 2024 13:20:59 +0530 Subject: [PATCH] Fix golangci-lint errors Signed-off-by: Sreekanth --- pkg/udf/forward/forward.go | 2 +- pkg/webhook/validator/validator.go | 5 ++++- test/transformer-e2e/transformer_test.go | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/udf/forward/forward.go b/pkg/udf/forward/forward.go index 53efc945da..e768808cc3 100644 --- a/pkg/udf/forward/forward.go +++ b/pkg/udf/forward/forward.go @@ -481,7 +481,7 @@ func (isdf *InterStepDataForward) streamMessage(ctx context.Context, dataMessage if len(dataMessages) > 1 { errMsg := "data message size is not 1 with map UDF streaming" isdf.opts.logger.Errorw(errMsg) - return nil, fmt.Errorf(errMsg) + return nil, errors.New(errMsg) } else if len(dataMessages) == 1 { // send to map UDF only the data messages diff --git a/pkg/webhook/validator/validator.go b/pkg/webhook/validator/validator.go index d5f2e86664..6d4e3e46a1 100644 --- a/pkg/webhook/validator/validator.go +++ b/pkg/webhook/validator/validator.go @@ -83,7 +83,10 @@ func GetValidator(ctx context.Context, NumaClient v1alpha1.NumaflowV1alpha1Inter // DeniedResponse constructs a denied AdmissionResponse func DeniedResponse(reason string, args ...interface{}) *admissionv1.AdmissionResponse { - result := apierrors.NewBadRequest(fmt.Sprintf(reason, args...)).Status() + if len(args) > 0 { + reason = fmt.Sprintf(reason, args) + } + result := apierrors.NewBadRequest(reason).Status() return &admissionv1.AdmissionResponse{ Result: &result, Allowed: false, diff --git a/test/transformer-e2e/transformer_test.go b/test/transformer-e2e/transformer_test.go index 77fae76814..8c07db744c 100644 --- a/test/transformer-e2e/transformer_test.go +++ b/test/transformer-e2e/transformer_test.go @@ -173,7 +173,7 @@ func (s *TransformerSuite) TestSourceTransformer() { } var wg sync.WaitGroup - wg.Add(4) + wg.Add(1) // FIXME: Enable these tests after corresponding SDKs are changed to support bidirectional streaming //go func() { // defer wg.Done()