Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIifPrint PDF splitting issues with mediated deposit workflows #233

Open
3 tasks
laritakr opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks

IIifPrint PDF splitting issues with mediated deposit workflows #233

laritakr opened this issue Feb 5, 2025 · 0 comments

Comments

@laritakr
Copy link
Contributor

laritakr commented Feb 5, 2025

Summary

PDF splitting does not work correctly when used with mediated deposit, resulting in a "black box" universal viewer.

  • unapproved child works do not appear in the universal viewer (not prior behavior)
  • child works remain in pending review status even after parent work is approved (prior behavior)
  • unapproved child works show in Items list for parent when not logged in (prior behavior)

Acceptance Criteria

  • Highest Priority Universal viewer shows pages, even when not approved
  • Some sort of method exists to approve all child works once the parent is approved (see notes below)
  • Unapproved child works do not appear in items list

Screenshots or Video

Behavior Before Valkyrization

Image

After clicking an item on items list:
Image

Behavior After Valkyrization

Image

After clicking an item on items list:

Image

Testing Instructions and Sample Files

To be filled out by dev

Notes

Several options to investigate for activating child works (in priority sequence):

  • Always make child works approved, rather than having them go through the mediated deposit workflow
  • Create a listener to automatically approve all spawned child works as the parent work is approved
  • Create a popup to approve all spawned child works as the parent work is approved. This may also require a button in the case where the parent is approved before the child works are completely created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant