Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Importer Edit page is not functional #191

Open
3 tasks done
ShanaLMoore opened this issue Jan 17, 2025 · 1 comment
Open
3 tasks done

🐛 Importer Edit page is not functional #191

ShanaLMoore opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels
bug something isn't working High Priority

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 17, 2025

Summary

Steps to reproduce
go to and importer on staging and click edit
the form seems to reveal much more than it should (ie: why are we seeing bagit inputs when the csv parser is selected?)
clicking to upload a new file does nothing

Image

Acceptance Criteria

  • It should only show the sections available to the previously selected importer partial
  • it should allow the user see the file path previously uploaded
  • it should allow the user to attach a new file [update: submitting it is not the issue. previously the user couldn't even click to upload when all the parser fields were displaying - regardless of which parser was selected]

Screenshots or Video

Testing Instructions

On Staging, find a previously created importer.
Click Edit
Verify that a user cannot see more than they should. For example, if CSV parser was selected, they should NOT see fields for BAGIT; they'll only see the fields related to importing a CSV.

Notes

issue reported by client:

@ShanaLMoore ShanaLMoore added High Priority bug something isn't working labels Jan 17, 2025
@ShanaLMoore ShanaLMoore changed the title Importer Edit page is not functional 🐛 Importer Edit page is not functional Jan 17, 2025
@ShanaLMoore ShanaLMoore self-assigned this Jan 17, 2025
@ShanaLMoore ShanaLMoore moved this to In Development in PalsKnapsack Jan 17, 2025
@ShanaLMoore ShanaLMoore moved this from In Development to Code Review in PalsKnapsack Jan 17, 2025
@sjproctor
Copy link
Contributor

sjproctor commented Jan 23, 2025

QA Results: ✅ Pass

Process

  • Tested on: Staging
  • Logged in > Dashboard > Importers

Test 1

  • Select import: test importers (status: complete, type: CSV)
  • Select edit
  • Confirm only CSV and ZIP import fields visible
  • Confirm user can see the file path of the previous import
  • Select Upload a File, select a CSV, select Update Importer, select Update Importer from Options for Updating the Importer modal
  • Confirm import was successful by clicking Download Original File

Image

Test 2

  • Select import: 5.4.2022 CTSFW D (status: pending, type: CSV)
  • Select edit
  • Confirm only CSV and ZIP import fields visible
  • Confirm user can see the file path of the previous import
  • Select Upload a File, select a CSV, select Update Importer, select Update Importer from Options for Updating the Importer modal
  • Confirm import was successful by clicking Download Original File

Image

  • Switching Parser to BagIt changes the visible import fields

Image

@sjproctor sjproctor moved this from Code Review to Client QA in PalsKnapsack Jan 23, 2025
@ndroark ndroark moved this from Client QA to Deploy to Production in PalsKnapsack Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working High Priority
Projects
Status: Deploy to Production
Development

No branches or pull requests

2 participants