Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Institutional Repository carousel does not work #189

Open
1 task done
laritakr opened this issue Jan 16, 2025 · 4 comments
Open
1 task done

Institutional Repository carousel does not work #189

laritakr opened this issue Jan 16, 2025 · 4 comments
Assignees
@sjproctor
Labels
High Priority

Comments

@laritakr
Copy link
Contributor

laritakr commented Jan 16, 2025 •
edited by sjproctor
Loading

Summary

Institutional repository homepage work type carousel does not work.

Acceptance Criteria

Screenshots or Video

Video: Reported issue on Pals

Currently
Image

Video: Expected behavior

HykuCommons Example
Image

Testing Instructions and Sample Files

  • Test on Pals staging
  • Ensure there works with at least six different resource types
  • Log in > Dashboard > Settings > Appearance > Themes
  • Home Page Theme > select Institutional Repository
  • On the home page, see the resource carousel
  • Click the left and right arrows to see the icons advance in a smooth, continuous loop

Notes

  • This PR removes the Bootstrap carousel since out-of-box functionality does not allow for multiple items on the screen and the workarounds were causing errors
  • This approach relies on jQuery to perform the icon transitions
  • All changes are made in Hyku and applied to Pals with a submodule update
@laritakr laritakr moved this to Ready for Development in PalsKnapsack Jan 16, 2025
@laritakr laritakr mentioned this issue Jan 16, 2025
Open
7 tasks
@jillpe jillpe moved this from Ready for Development to In Development in PalsKnapsack Jan 21, 2025
@sjproctor
Copy link
Contributor

look into Blacklight carousel gem

sjproctor added a commit to samvera/hyku that referenced this issue Jan 25, 2025
@sjproctor
🚧 WIP Institutional Repository carousel
aee5af9 
This commit:
- removes Bootstrap carousel due to the limitations of Bootstrap's built
in functionality in favor of creating a custom carousel

Ref:
- notch8/palni_palci_knapsack#189
sjproctor added a commit to samvera/hyku that referenced this issue Jan 25, 2025
@sjproctor
🐛 Institutional Repository Resources Carousel
4fb0193 
This commit removes the bootstrap carousel from the Institutional Repository
homepage and replaces it with a custom slider.

Bootstrap carousel functionality does not align with the functionality
needed for the Institutional Repository resources slider.

Ref:
- notch8/palni_palci_knapsack#189
@sjproctor sjproctor mentioned this issue Jan 25, 2025
Merged
@sjproctor sjproctor moved this from In Development to Code Review in PalsKnapsack Jan 27, 2025
@sjproctor sjproctor moved this from Code Review to SoftServ QA in PalsKnapsack Jan 27, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 28, 2025 •
edited
Loading

QA RESULTS: ✅ PASS

tested on STAGING

Acceptance Criteria

Image

Testing Instructions and Sample Files

  • - Test on Pals staging
  • - Ensure there works with at least six different resource types
  • - Log in > Dashboard > Settings > Appearance > Themes
  • - Home Page Theme > select Institutional Repository
  • - On the home page, see the resource carousel
  • - Click the left and right arrows to see the icons advance in a smooth, continuous loop

Image

@ShanaLMoore ShanaLMoore moved this from SoftServ QA to Client QA in PalsKnapsack Jan 28, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 28, 2025 •
edited
Loading

cc @laritakr does this require client review? If this is self reported we can close it.

@ndroark ndroark moved this from Client QA to Deploy to Production in PalsKnapsack Jan 29, 2025
@laritakr
Copy link
Contributor Author

Probably not, since we made the ticket and it was a spinoff from the general homepage issues ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjproctor sjproctor

Labels
High Priority
Projects
PalsKnapsack
Status: Deploy to Production
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @laritakr @sjproctor