Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with fonts #178

Open
7 of 9 tasks
Tracked by #170
laritakr opened this issue Dec 2, 2024 · 2 comments
Open
7 of 9 tasks
Tracked by #170

Issues with fonts #178

laritakr opened this issue Dec 2, 2024 · 2 comments
Assignees
@kirkkwang
Labels
High Priority

Comments

@laritakr
Copy link
Contributor

laritakr commented Dec 2, 2024 •
edited
Loading

Story

Verify if any issues exist in Hyku and fix in appropriate location.

  • marketing message doesn’t use a chosen font
  • wrong fonts are used in some cases
    • homepage featured collection titles (wrong) use a different font than featured works titles
    • catalog page
      • facet “limit your search” label
      • work titles
  • “select body font” and “select header font” are right justified on the tab instead of above the select font dropdowns
  • restore default buttons work individually but restore all defaults does nothing (possibly fixed)
  • verify fonts are used correctly in all of the themes

Acceptance Criteria

  • Marketing message uses the chosen font
  • Homepage featured collection and featured works titles uses the chosen font
  • In the catalog page, "Limit your search" uses the chosen font
  • In the catalog page, result titles use the chosen font
  • In Appearance, fonts tab, "Select body font" and "Select header font" are aligned above their respective dropdowns
  • In Appearance, fonts tab, "Restore all defaults" button works properly
  • Fonts are used correctly in all themes

Screenshots / Video

Testing Instructions and Sample Files

  • In the Admin > Appearance > Fonts tab, choose some fonts
  • Confirm all Acceptance Criteria

Notes
@laritakr laritakr mentioned this issue Dec 2, 2024
Open
19 tasks
@jillpe
Copy link

jillpe commented Jan 13, 2025

involves hyku and pals

@kirkkwang kirkkwang self-assigned this Jan 23, 2025
@kirkkwang kirkkwang mentioned this issue Jan 24, 2025
Merged
kirkkwang added a commit that referenced this issue Jan 24, 2025
@kirkkwang
⬆️ Update submodule
8f4721e 
Update submodule to bring in font fixes.

Ref:
  - samvera/hyku#2430
  - #178
@kirkkwang kirkkwang mentioned this issue Jan 24, 2025
Merged
@jillpe jillpe moved this to SoftServ QA in PalsKnapsack Jan 27, 2025
kirkkwang added a commit to samvera/hyku that referenced this issue Jan 29, 2025
@kirkkwang
🐛 Fix visual bug with fonts selection label
65f70f9 
This commit will align the label of the fonts selection label over the
dropdown.

Ref:
- notch8/palni_palci_knapsack#178
@kirkkwang kirkkwang mentioned this issue Jan 29, 2025
Merged
kirkkwang added a commit that referenced this issue Jan 29, 2025
@kirkkwang
⬆️ Update submodule
576d38a 
This commit will bring in a pinned version of Hyrax because Hyrax
recently released their Rails 7.2 upgrade.  Also, it will bring in a fix
for the fonts.

Ref:
- samvera/hyku#2435
- samvera/hyku#2436
- #178
@kirkkwang kirkkwang mentioned this issue Jan 29, 2025
Merged
@laritakr
Copy link
Contributor Author

laritakr commented Jan 31, 2025 •
edited
Loading

QA RESULTS: ✅ Passed

On the demo site, font behavior was very inconsistent between pages & themes, so no direct comparison could be made to be sure that the heading vs body fonts are consistent with prior behavior.

As shown below, fonts selection now controls the public site for each theme. If future changes are desired re: which font is used in any specific location, a new ticket can be created for that specific change.

Default Theme

Screenshots

Homepage

Image

Cultural Theme

Screenshots

Homepage

Image

Institutional Theme

Screenshots

Homepage

Image

Neutral Theme

Screenshots

Homepage

Image

Catalog Search Page

Screenshots

Image

Collection Show Page

Screenshots

Image

Default Show Page

Screenshots

Image

Cultural Show Page

Screenshots

Image

Scholarly Show Page

Screenshots

Image

Reshare Show Page

Screenshots

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laritakr @kirkkwang @jillpe