Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie: Importer and Exporter index page error #758

Closed
1 task
KatharineV opened this issue Aug 20, 2024 · 10 comments
Closed
1 task

Valkyrie: Importer and Exporter index page error #758

KatharineV opened this issue Aug 20, 2024 · 10 comments

Comments

@KatharineV
Copy link
Collaborator

KatharineV commented Aug 20, 2024

When I try to sort importers on ADL Staging, the Last Run and Next Run sort features don't work. They generate the following error message. We need these sort features to work because we use them frequently while managing our importers, and they worked prior to the latest upgrade.

Image

Acceptance Criteria

  • A user should be able to sort and paginate through the importer and exporter tables
@ShanaLMoore
Copy link

ShanaLMoore commented Sep 5, 2024

the server logs produces this error: 🤔

Image

this is happening for pals and utk as well

all migrations are up

@ShanaLMoore ShanaLMoore self-assigned this Sep 12, 2024
@ShanaLMoore ShanaLMoore removed their assignment Sep 12, 2024
@ShanaLMoore ShanaLMoore changed the title Valkyrie: Importer index page error Valkyrie: Importer and Exporter index page error Sep 12, 2024
@kirkkwang kirkkwang assigned kirkkwang and unassigned kirkkwang Sep 12, 2024
@jillpe jillpe moved this from Ready for Development to Code Review in Adventist Knapsack Sep 17, 2024
ShanaLMoore pushed a commit that referenced this issue Sep 19, 2024
Pulls in fixes bulkrax datatable sort.
- #758
@ShanaLMoore ShanaLMoore moved this from Code Review to Deploy to Staging in Adventist Knapsack Sep 19, 2024
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to SoftServ QA in Adventist Knapsack Sep 20, 2024
@ShanaLMoore
Copy link

ShanaLMoore commented Sep 20, 2024

QA RESULTS: ✅ PASS

tested on STAGING

Acceptance Criteria

  • A user should be able to sort and paginate through the importer and exporter tables

IMPORTERS

Image

EXPORTERS

Image

@KatharineV
Copy link
Collaborator Author

Confirmed: it as expected for importers and exporters when I try to sort and page through on multiple staging tenants.

@KatharineV
Copy link
Collaborator Author

Folks, the importer "last run" sort feature was fixed on staging, but post cutover, it's not working correctly on prod. I can tell it isn't working correctly because we have at least 27 importers that I recorded myself as running between April 2024 and the present, and the sort that should show most recent importers at the top is only showing one from 2024.

Importer page prior to any sort:
Image

Clicked Last Run once:
Image

Clicked Last Run a second time:
Image

@ShanaLMoore
Copy link

In prod we needed to run a command to fix this. I just ran it, could you try again and let me know if you still see the problem @KatharineV

for future self: rake bulkrax:update_status_messages

@ShanaLMoore
Copy link

ShanaLMoore commented Nov 11, 2024

cc @KatharineV actually I still see the issue. We'll need to have a closer look

dev note

ref: samvera/bulkrax#977

do we need to wrap this task to check for Hyku and account.switch! if so? example:

if defined?(::Hyku)
      Account.find_each do |account|
        next if account.name == "search"
        switch!(account)
        puts "=============== updating #{account.name} ============"

        update_status_message

        puts "=============== finished updating #{account.name} ============"
      end
    else
        update_status_message
    end
  end

@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Ready for Development in Adventist Knapsack Nov 11, 2024
@ShanaLMoore
Copy link

bundle exec rake bulkrax:resave_importers was the command that needed to be run

@ShanaLMoore
Copy link

@KatharineV Please try again: demo

@ShanaLMoore ShanaLMoore moved this from Ready for Development to Client Verification in Adventist Knapsack Nov 13, 2024
@KatharineV
Copy link
Collaborator Author

@ShanaLMoore yes, I can confirm I see the Last Run sort working on prod now. Thanks!

@jillpe jillpe closed this as completed Nov 18, 2024
@github-project-automation github-project-automation bot moved this from Client Verification to Done in Adventist Knapsack Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants