From 43d625c4c6489c05ecace8cc45cd65ba2594ae99 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 18:10:42 +0000 Subject: [PATCH 1/8] chore: remove malformed functions from brillig reports --- test_programs/gates_report_brillig.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_programs/gates_report_brillig.sh b/test_programs/gates_report_brillig.sh index d3f6344dbf4..130b63b549f 100755 --- a/test_programs/gates_report_brillig.sh +++ b/test_programs/gates_report_brillig.sh @@ -28,6 +28,6 @@ done echo "]" >> Nargo.toml -nargo info --force-brillig --json > gates_report_brillig.json +nargo info --force-brillig --json | jq -r "del(.programs[].functions)" > gates_report_brillig.json rm Nargo.toml From d9d0142239983b00e67bc261f9815b37506582d7 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 18:16:55 +0000 Subject: [PATCH 2/8] . --- test_programs/gates_report_brillig.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_programs/gates_report_brillig.sh b/test_programs/gates_report_brillig.sh index 130b63b549f..7343857a3c5 100755 --- a/test_programs/gates_report_brillig.sh +++ b/test_programs/gates_report_brillig.sh @@ -28,6 +28,6 @@ done echo "]" >> Nargo.toml -nargo info --force-brillig --json | jq -r "del(.programs[].functions)" > gates_report_brillig.json +nargo info --force-brillig --json | jq -r ".programs[].functions = []" > gates_report_brillig.json rm Nargo.toml From 3db44b4bd024be12ba3ed7fbd82eee39aea5688d Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 18:17:57 +0000 Subject: [PATCH 3/8] . --- test_programs/gates_report_brillig_execution.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test_programs/gates_report_brillig_execution.sh b/test_programs/gates_report_brillig_execution.sh index b3f4a8bda98..bd81d7d20f9 100755 --- a/test_programs/gates_report_brillig_execution.sh +++ b/test_programs/gates_report_brillig_execution.sh @@ -38,6 +38,6 @@ done echo "]" >> Nargo.toml -nargo info --profile-execution --json > gates_report_brillig_execution.json +nargo info --profile-execution --json | jq -r ".programs[].functions = [] > gates_report_brillig_execution.json -rm Nargo.toml \ No newline at end of file +rm Nargo.toml From 91aea504e6d0d343aa6760c5c316fc54625eea66 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 18:49:56 +0000 Subject: [PATCH 4/8] . --- .github/workflows/reports.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reports.yml b/.github/workflows/reports.yml index 86a59310f6f..3e3aecc3afc 100644 --- a/.github/workflows/reports.yml +++ b/.github/workflows/reports.yml @@ -76,7 +76,7 @@ jobs: - name: Compare gates reports id: gates_diff - uses: noir-lang/noir-gates-diff@1931aaaa848a1a009363d6115293f7b7fc72bb87 + uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 with: report: gates_report.json summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) @@ -121,7 +121,7 @@ jobs: - name: Compare Brillig bytecode size reports id: brillig_bytecode_diff - uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48 + uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 with: report: gates_report_brillig.json header: | @@ -170,7 +170,7 @@ jobs: - name: Compare Brillig execution reports id: brillig_execution_diff - uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48 + uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 with: report: gates_report_brillig_execution.json header: | From 780b015441cdda54643b2ff049dfda88c6f30d57 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 18:53:45 +0000 Subject: [PATCH 5/8] . --- test_programs/gates_report_brillig_execution.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_programs/gates_report_brillig_execution.sh b/test_programs/gates_report_brillig_execution.sh index bd81d7d20f9..6a5a699e2d8 100755 --- a/test_programs/gates_report_brillig_execution.sh +++ b/test_programs/gates_report_brillig_execution.sh @@ -38,6 +38,6 @@ done echo "]" >> Nargo.toml -nargo info --profile-execution --json | jq -r ".programs[].functions = [] > gates_report_brillig_execution.json +nargo info --profile-execution --json | jq -r ".programs[].functions = []" > gates_report_brillig_execution.json rm Nargo.toml From fedef5331d996b5a8a222e9190bffcfe355f8128 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 19:02:47 +0000 Subject: [PATCH 6/8] . --- test_programs/gates_report.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_programs/gates_report.sh b/test_programs/gates_report.sh index b7698f1ca78..c92346f40e8 100755 --- a/test_programs/gates_report.sh +++ b/test_programs/gates_report.sh @@ -24,7 +24,7 @@ for pathname in $test_dirs; do fi GATES_INFO=$($BACKEND gates -b "$artifacts_path/$ARTIFACT_NAME/target/program.json") - MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}]}") + MAIN_FUNCTION_INFO=$(echo $GATES_INFO | jq -r ".functions[0] | {package_name: "\"$ARTIFACT_NAME\"", functions: [{name: \"main\", acir_opcodes, opcodes: .acir_opcodes, circuit_size}], unconstrained_functions: []}") echo -n $MAIN_FUNCTION_INFO >> gates_report.json if (($ITER == $NUM_ARTIFACTS)); then From c0f4910d211e03374428fde5b121a3b84908cf79 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 19:25:33 +0000 Subject: [PATCH 7/8] . --- .github/workflows/reports.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reports.yml b/.github/workflows/reports.yml index 3e3aecc3afc..6fbcddade9a 100644 --- a/.github/workflows/reports.yml +++ b/.github/workflows/reports.yml @@ -76,7 +76,7 @@ jobs: - name: Compare gates reports id: gates_diff - uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 + uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 with: report: gates_report.json summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) @@ -121,7 +121,7 @@ jobs: - name: Compare Brillig bytecode size reports id: brillig_bytecode_diff - uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 + uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 with: report: gates_report_brillig.json header: | @@ -170,7 +170,7 @@ jobs: - name: Compare Brillig execution reports id: brillig_execution_diff - uses: noir-lang/noir-gates-diff@d5fb85deaaf8af176aa98fbb945394d5e207c227 + uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 with: report: gates_report_brillig_execution.json header: | From 0b7aefcbbc9288464189cb1b14a17519edb6a2a5 Mon Sep 17 00:00:00 2001 From: Tom French Date: Fri, 20 Dec 2024 19:27:00 +0000 Subject: [PATCH 8/8] . --- .github/workflows/reports.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reports.yml b/.github/workflows/reports.yml index 6fbcddade9a..f7fe78f6565 100644 --- a/.github/workflows/reports.yml +++ b/.github/workflows/reports.yml @@ -76,7 +76,7 @@ jobs: - name: Compare gates reports id: gates_diff - uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 + uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175 with: report: gates_report.json summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) @@ -121,7 +121,7 @@ jobs: - name: Compare Brillig bytecode size reports id: brillig_bytecode_diff - uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 + uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175 with: report: gates_report_brillig.json header: | @@ -170,7 +170,7 @@ jobs: - name: Compare Brillig execution reports id: brillig_execution_diff - uses: noir-lang/noir-gates-diff@2b3906a9432b66bf3361e6ca15baa582795e4e89 + uses: noir-lang/noir-gates-diff@84ada11295b9a1e1da7325af4e45e2db9f775175 with: report: gates_report_brillig_execution.json header: |