Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need mdns lib? #15

Open
nabbl opened this issue Aug 21, 2017 · 2 comments
Open

Do we really need mdns lib? #15

nabbl opened this issue Aug 21, 2017 · 2 comments
Assignees

Comments

@nabbl
Copy link

nabbl commented Aug 21, 2017

It really makes the install kind of problematic... and if you npm install again you would need to do the change in the browser.js file again.

Instead of trying to resolve the DNS like that the user should be able to just use the IP adress of the Google Home. Makes things a lot easier in my opinion.

@noelportugal
Copy link
Owner

Agree!

@nouknouk
Copy link

a workaround for linux users is to put the fix in the npm package.json file referencing the google-home-notifier.

The following seems to work for me:

  "scripts": {
    "postinstall": "sed -i -e 's/getaddrinfo()/getaddrinfo({families\\:\\[4\\]\\})/g' node_modules/mdns/lib/browser.js"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants