Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New track for Node.js 16 #6

Closed
7 tasks done
rvagg opened this issue Apr 20, 2021 · 1 comment
Closed
7 tasks done

New track for Node.js 16 #6

rvagg opened this issue Apr 20, 2021 · 1 comment

Comments

@rvagg
Copy link
Member

rvagg commented Apr 20, 2021

According to plan @ https://github.com/nodejs/snap/#adding-new-release-lines

  1. Get a new track for the "node" Snap - in progress https://forum.snapcraft.io/t/track-request-for-node-16-fast-track-please/23969
  2. Create a new branch named node16
  3. Fix up snapcraft.yaml.sh for 16
  4. Add 16 to the GitHub Actions matrix
  5. Trigger manual build to get a push to Launchpad
  6. Create Snap workflow in Launchpad for 16
  7. Trigger manual builds in Launchpad for 16.0.0

I'd also like to try and make the switch to core20 for 16+. I should have tried this earlier for nightlies/master but #3 has me a bit concerned about trailing too far behind modern glibc for an LTS. See https://snapcraft.io/docs/base-snaps for documentation on bases. It may not be possible to use core20 for reasons mentioned in there but I'd like to give it a go.

rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
rvagg added a commit that referenced this issue Apr 21, 2021
@rvagg
Copy link
Member Author

rvagg commented Apr 21, 2021

$ sudo snap refresh node --channel 16
node (16/stable) 16.0.0 from OpenJS Foundation (iojs✓) refreshed
$ node -v
v16.0.0

x64 is built at least, core20. But, core20 has meant we have to drop x86 from 16+. I think there might be a creative way around this by setting up a separate build that also publishes to the 16 track but using a different config, but that's getting kind of complicated and I think I'd prefer to defer it until we have user demand or someone else wants to contribute to making that happen.

I've pushed core20 to the edge (master) build too and dropped x86 from there as well.

@rvagg rvagg closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant