-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-bot broken? #3720
github-bot broken? #3720
Comments
post-build-status-update at first glance looks green, but clicking on the jobs and looking at the "Pipeline steps", e.g. https://ci.nodejs.org/job/post-build-status-update/2261443/flowGraphTable/, shows that the "httpRequest" step failed. The console output can't find the build log, e.g. java.io.FileNotFoundException: /var/lib/jenkins/jobs/post-build-status-update/builds/2261443/log (No such file or directory)
at java.base/java.io.RandomAccessFile.open0(Native Method)
... I'll see if I can find it on the Jenkins server (I think they get compressed there). |
On root@infra-digitalocean-ubuntu14-x64-1:~# ls -al /var/lib/jenkins/jobs/post-build-status-update/builds/2261443
total 976
drwxr-xr-x 3 jenkins jenkins 4096 May 14 07:56 .
drwxr-xr-x 102 jenkins jenkins 933888 May 14 08:37 ..
-rw-r--r-- 1 jenkins jenkins 35675 May 14 07:56 build.xml
-rw-r--r-- 1 jenkins jenkins 0 May 14 07:56 changelog1986113076434187246.xml
-rw-r--r-- 1 jenkins jenkins 6021 May 14 07:56 log.gz
-rw-r--r-- 1 jenkins jenkins 102 May 14 07:56 log-index
drwxr-xr-x 2 jenkins jenkins 4096 May 14 07:56 workflow
root@infra-digitalocean-ubuntu14-x64-1:~# From the uncompressed log:
|
The bot isn't running -- on root@infra-rackspace-debian8-x64-1:~# systemctl status github-bot
● github-bot.service - github-bot
Loaded: loaded (/lib/systemd/system/github-bot.service; enabled)
Active: activating (auto-restart) (Result: exit-code) since Tue 2024-05-14 13:00:13 UTC; 8s ago
Process: 29335 ExecStart=/usr/bin/node server.js (code=exited, status=1/FAILURE)
Main PID: 29335 (code=exited, status=1/FAILURE)
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: code: 'MODULE_NOT_FOUND',
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: requireStack: [
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: '/home/iojs/github-bot/node_modules/path-scurry/dist/commonjs/index.js',
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: '/home/iojs/github-bot/node_modules/glob/dist/commonjs/glob.js',
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: '/home/iojs/github-bot/node_modules/glob/dist/commonjs/index.js',
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: '/home/iojs/github-bot/server.js'
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: ]
May 14 13:00:13 infra-rackspace-debian8-x64-1 node[29335]: }
May 14 13:00:13 infra-rackspace-debian8-x64-1 systemd[1]: github-bot.service: main process exited, code=exited, status=1/FAILURE
May 14 13:00:13 infra-rackspace-debian8-x64-1 systemd[1]: Unit github-bot.service entered failed state.
root@infra-rackspace-debian8-x64-1:~# |
From
which is #3214 and the inability to update Node.js there until we update the OS all over again. |
Landed 18 hours ago. |
Can't we update Node.js to 14.21.3 (the last 14.x version), or at least 14.18? isaacs/node-glob@57f5551 |
Oof, sorry I did this with that |
If upgrading to Node.js 14.18 or later is trouble, and even if it's not, a quick fix would be to revert the |
This reverts commit c5ba723. Fixes: nodejs/build#3720
Oops, probably not because the bot will still install the latest |
We can unpin it once the bot is running on Node.js 14.18 or newer. Fixes: nodejs/build#3720
nodejs/github-bot#511 for a temporary workaround |
FWIW |
We can unpin it once the bot is running on Node.js 14.18 or newer. Fixes: nodejs/build#3720
Hmm, pinning |
Is the machine still in sync with its playbook? If it's not, I suggest we remove the Node.js installed via |
I've downloaded Node.js 14.21.3 onto the machine and extracted it to root@infra-rackspace-debian8-x64-1:/home/iojs# systemctl status github-bot
● github-bot.service - github-bot
Loaded: loaded (/lib/systemd/system/github-bot.service; enabled)
Active: active (running) since Wed 2024-05-15 17:52:29 UTC; 1s ago
Main PID: 19176 (node)
CGroup: /system.slice/github-bot.service
└─19176 /usr/local/bin/node server.js
May 15 17:52:29 infra-rackspace-debian8-x64-1 systemd[1]: Started github-bot.
May 15 17:52:29 infra-rackspace-debian8-x64-1 node[19176]: {"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":19176,"level":30,"msg":"Loading: ./scripts/ping.js","time":"2024-05-15T1...591Z","v":0}
May 15 17:52:29 infra-rackspace-debian8-x64-1 node[19176]: {"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":19176,"level":30,"msg":"Loading: ./scripts/node-ping-owners.js","time":"...595Z","v":0}
May 15 17:52:29 infra-rackspace-debian8-x64-1 node[19176]: {"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":19176,"level":30,"msg":"Loading: ./scripts/jenkins-status.js","time":"20...687Z","v":0}
May 15 17:52:29 infra-rackspace-debian8-x64-1 node[19176]: {"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":19176,"level":30,"msg":"Loading: ./scripts/event-relay.js","time":"2024-...688Z","v":0}
May 15 17:52:29 infra-rackspace-debian8-x64-1 node[19176]: {"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":19176,"level":30,"msg":"Listening on port 3333","time":"2024-05-15T17:52...693Z","v":0}
Hint: Some lines were ellipsized, use -l to show in full.
root@infra-rackspace-debian8-x64-1:/home/iojs# |
httpRequest step in the pipeline (see #3720 (comment)) is passing now and I can see status checks being posted back to PRs. |
@richardlau Should we land nodejs/github-bot#514 and keep an eye on things? |
I noticed that the bot reported starting a CI run in nodejs/node#52973 (comment) but no following comment linking to the Jenkins run nor statuses posted back to the PR. It looks like a Jenkins run was started: https://ci.nodejs.org/job/node-test-pull-request/59205/
The text was updated successfully, but these errors were encountered: