-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sharktank] Test failures with torch>=2.4.0
#495
Comments
|
As needed, we can put branches in the code based on the pytorch version, or just warn/error if an incompatible version is installed. class PytorchGELUTanh(nn.Module):
def __init__(self):
super().__init__()
if version.parse(torch.__version__) < version.parse("1.12.0"):
raise ImportError(
f"You are using torch=={torch.__version__}, but torch>=1.12.0 is required to use "
"PytorchGELUTanh. Please upgrade torch."
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using Python 3.11.9, sharktank at HEAD fails when using a more recent torch version. In the CI, torch is pinned to 2.3.0:
https://github.com/nod-ai/SHARK-Platform/blob/903d3c1ac63c4e9b8a013a29eeca9a8ed7047e9f/.github/workflows/ci-sharktank.yml#L61
https://github.com/nod-ai/SHARK-Platform/blob/903d3c1ac63c4e9b8a013a29eeca9a8ed7047e9f/pytorch-cpu-requirements.txt#L3
When upgrading to a more recent version, the following tests fail:
torch==2.4.0
andtorch==2.4.1
torch==2.5.0
andtorch==2.5.1
The text was updated successfully, but these errors were encountered: