From 4cc3f02e47954f904953a218fe795bf31741e141 Mon Sep 17 00:00:00 2001 From: Scott Todd Date: Fri, 10 Jan 2025 11:10:00 -0800 Subject: [PATCH] [shortfin] Add a tracing enabled CI job. (#812) Also update the pinned IREE commit used for building shortfin now that a fix for Tracy on gcc has landed. --- .github/workflows/ci-libshortfin.yml | 10 ++++++++-- shortfin/CMakeLists.txt | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-libshortfin.yml b/.github/workflows/ci-libshortfin.yml index 299212657..9a514e7a6 100644 --- a/.github/workflows/ci-libshortfin.yml +++ b/.github/workflows/ci-libshortfin.yml @@ -64,6 +64,12 @@ jobs: python-version: "3.12" cmake-options: -DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14 + - name: Ubuntu (GCC 14, tracing) + runs-on: ubuntu-24.04 + # Only test with GCC 14 and Python 3.12 + python-version: "3.12" + cmake-options: + -DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14 -DSHORTFIN_ENABLE_TRACING=ON - name: Windows (MSVC) runs-on: windows-2022 exclude: @@ -121,13 +127,13 @@ jobs: cmake --build build --target all - name: pip install shortfin - if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)'}} + if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)' && !contains(matrix.name, 'tracing') }} working-directory: ${{ env.LIBSHORTFIN_DIR }} run: | pip install -v -e build/ - name: Test shortfin - if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)'}} + if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)' && !contains(matrix.name, 'tracing') }} working-directory: ${{ env.LIBSHORTFIN_DIR }} run: | ctest --timeout 30 --output-on-failure --test-dir build diff --git a/shortfin/CMakeLists.txt b/shortfin/CMakeLists.txt index c6368f2c5..ec3005482 100644 --- a/shortfin/CMakeLists.txt +++ b/shortfin/CMakeLists.txt @@ -49,7 +49,7 @@ add_compile_options("$<$:/utf-8>") # packages must be compatible with the runtime at this source ref. # TODO: switch back to iree-3.2.0rcYYYYMMDD style tag matching Python package # pin after future nightly releases -set(SHORTFIN_IREE_GIT_TAG "9055c9d1f6342a061a6747ef9b385816b96a0a8f") +set(SHORTFIN_IREE_GIT_TAG "039b8b4ba8e57a3c148cd8f73370a973d64df202") # build options