Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dry point #76

Open
saeed-moghimi-noaa opened this issue Mar 10, 2022 · 3 comments
Open

Handle dry point #76

saeed-moghimi-noaa opened this issue Mar 10, 2022 · 3 comments
Assignees

Comments

@saeed-moghimi-noaa
Copy link

No description provided.

@saeed-moghimi-noaa
Copy link
Author

@WPringle Please document the problem and your current solution. Thanks.

@ghost
Copy link

ghost commented Mar 14, 2022

currently, the issue is that a large amount of mesh nodes are dry (NaN water elevation) throughout the ensemble space. These nodes are not all colocated; one particular mesh node might be dry in one ensemble member and wet in another. This is problematic for the polynomial fitting, as it expects to be fitting to a continuous function of water elevation.

The initial solution was to assign all dry nodes in the study area a minimum (near-zero) water elevation value. This allowed the polynomial to run, but it is not an ideal solution because the minimum value acts as a totally flat plateau of water elevation, and the accuracy of the resulting surrogate reflected that.

The new solution is to assign dry nodes a "real" water elevation with linear falloff away from the nearest true wet node. This allows the polynomial to fit to a gradient curve instead of to a discontinuous plateau.

@WPringle
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants