Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: testing of the cmd pkg to avoid regressions #12

Closed
Avokadoen opened this issue Mar 6, 2021 · 0 comments · Fixed by #13
Closed

Feature: testing of the cmd pkg to avoid regressions #12

Avokadoen opened this issue Mar 6, 2021 · 0 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@Avokadoen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Draft of PR #3 introduced sever regression. To avoid merging regressions in the master there should be cmd tests to verify that all commands and arguments works as expected

Describe the solution you'd like
Unit tests for each command and argument combination

Describe alternatives you've considered
None

Additional context
https://medium.com/swlh/unit-testing-cli-programs-in-go-6275c85af2e7
@Avokadoen Avokadoen added the enhancement New feature or request label Mar 6, 2021
Avokadoen added a commit to Avokadoen/gowarcserver that referenced this issue Mar 7, 2021
@Avokadoen
WIP: nlnwa#12: tests for cmd functionality
c232a72
Avokadoen added a commit to Avokadoen/gowarcserver that referenced this issue Mar 10, 2021
@Avokadoen
WIP: nlnwa#12: tests for cmd functionality
73ef981
Avokadoen added a commit to Avokadoen/gowarcserver that referenced this issue Mar 12, 2021
@Avokadoen
WIP: nlnwa#12: tests for cmd functionality
5bf49dc
Avokadoen added a commit to Avokadoen/gowarcserver that referenced this issue Mar 22, 2021
@Avokadoen
nlnwa#12: tests for cmd functionality
f3425e0 
Got some help by @maeb to resolve test data issues :)
@Avokadoen Avokadoen linked a pull request Mar 28, 2021 that will close this issue
tests for cmd functionality #13
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests for cmd functionality Avokadoen/gowarcserver
1 participant
@Avokadoen