Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links don't work properly for some medias with special characters such as "&" #48

Open
AmineI opened this issue Jun 3, 2020 · 0 comments

Comments

@AmineI
Copy link

AmineI commented Jun 3, 2020

For example, external links for Wallace & Gromit sends a Google search for "Wallace", because the "&" character is interpreted as ending the query parameter.

It should be simple enough to fix : Passing the title through an encodeURIComponent before creating the external link url.

I'll push a fix in #47 , but still logging the issue in case the PR is not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants