Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMash need not be run with kmer sizes down to 30 #4

Closed
dkoslicki opened this issue Nov 25, 2019 · 5 comments
Closed

CMash need not be run with kmer sizes down to 30 #4

dkoslicki opened this issue Nov 25, 2019 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request low priority

Comments

@dkoslicki
Copy link
Collaborator

In this line, we do not need CMash to be run with 30-60-10, as we only use 60-mers in the downstream analysis.

@dkoslicki dkoslicki self-assigned this Nov 25, 2019
@nlapier2
Copy link
Owner

What should I replace that with? Can I just do "60" or would I have to do something like "60-60-10"? Would I also have to re-do the filter?

@dkoslicki
Copy link
Collaborator Author

You would not need to redo the filter. Also, 60-60-10 will work (but note that it will change the dimensions of the resulting tsv file, but this might not matter if you just take the last column in your code currently).

@nlapier2
Copy link
Owner

nlapier2 commented Dec 9, 2019

Changing to 60-60-10 for the StreamingQueryDNADatabase call seems to change the results (even though I only took the last column originally)... does this make any sense?

@dkoslicki
Copy link
Collaborator Author

That's odd! It really shouldn't change things, but I would need to look into this further...

@dkoslicki dkoslicki added low priority enhancement New feature or request labels Dec 11, 2019
@dkoslicki dkoslicki added the bug Something isn't working label Jan 21, 2020
@dkoslicki
Copy link
Collaborator Author

This issue has now been fixed. See here for more details. Will be implemented in next release of CMash. In short, reverse complements were not being added to the ternary search trie (and a few other insidious bugs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants