Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge programs leave behind artifacts #17

Open
nixpulvis opened this issue Oct 15, 2018 · 1 comment
Open

Bridge programs leave behind artifacts #17

nixpulvis opened this issue Oct 15, 2018 · 1 comment
Labels
F: shebang-block The bridge `{#!}` syntax. L1: bug Requires a fix T: io Topic: Input and output related issues

Comments

@nixpulvis
Copy link
Owner

We currently implement bridged programs as files in /tmp/oursh_bridge-<size>, but this is not a good idea. First of all history should be the only place we deal with old commands, and second, it's a data locking nightmare trying to negotiate for the same file. Worse, a program with the same interpreter and length will override the same program file, potentially causing catastrophic effect.

@nixpulvis nixpulvis added the L1: bug Requires a fix label Oct 15, 2018
@nixpulvis nixpulvis added this to the Interoperability milestone Oct 15, 2018
@nixpulvis nixpulvis added the T: io Topic: Input and output related issues label Oct 16, 2018
@nixpulvis
Copy link
Owner Author

This was implemented like this to actually make use of the systems #! functionality, however there's no real reason we can't create a Job with the correct executable path, and pipe the text into it. This should speed things up considerable as well.

@nixpulvis nixpulvis added the F: shebang-block The bridge `{#!}` syntax. label Oct 20, 2018
@nixpulvis nixpulvis removed this from the Interoperability milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: shebang-block The bridge `{#!}` syntax. L1: bug Requires a fix T: io Topic: Input and output related issues
Projects
None yet
Development

No branches or pull requests

1 participant