Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut for "Import Icon from Owning Library..." action #19

Closed
RobustoSystems opened this issue Jun 13, 2024 · 4 comments
Closed
Assignees

Comments

@RobustoSystems
Copy link

As a LabVIEW user, I would appreciate being able to more quickly execute the "Import Icon from Owning Library..." action.

1 (edited)

This is a repetitive action that I perform several times each day, sometimes dozens of times a day.

I would be happy with any key combination chosen for this action.

Side-note: It would be great if, when moving a VI or CTL from one owner to another, the LabVIEW IDE would be able to automatically update the "banner" of the VI with that of the new owning lvclass or lvlib. This feature would remove 90% of the instances where I need to use the "Import Icon from Owning Library..." action. But I know that this is not the place to ask for this feature.

Thanks!

@RobustoSystems
Copy link
Author

RobustoSystems commented Jun 13, 2024

Optional feature extension:
During its loading/start-up procedure the Icon Editor could detect if the VI/CTL has the "wrong" banner (banner does not match current owner banner). If that is the case, the Icon Editor could display a two button dialogue containing a message such as:

"This VI does not use the banner of its owner, "name of owner here". Would you like the banner to be applied?"

If the user selects "Yes" (or hits Enter), the Icon Editor would execute the "Import Icon from Owning Library..." action for the user.

Benefits:

  • This functionality would act like a mini VI analyser. It would help catch this issue.
  • Clicking Yes (or hitting Enter) would be even quicker than executing the keyboard shortcut.
    Downsides:
  • Performing the check may slow down the start-up sequence. This may be a significant drawback.

@elijah286 elijah286 moved this to Backlog in Icon Editor Jun 21, 2024
@crossrulz
Copy link
Collaborator

If going the dialog on load, also enable a checkbox to "Always Apply".

@svelderrainruiz
Copy link
Collaborator

svelderrainruiz commented Oct 8, 2024

For the purpose of closing this PR, i will develop the keyboard shortcut on the icon editor and will open a new issue that explores the route of automatically applying the banner from the parent library as described on this issue's comments

@RobustoSystems
Copy link
Author

Thanks for looking into this. It's much appreciated.

Kind regards,
Petru Tarabuta, Robusto Systems Ltd, UK

svelderrainruiz added a commit to svelderrainruiz/labview-icon-editor that referenced this issue Oct 8, 2024
CTRL+I Now imports icon from owning library on icon editor
svelderrainruiz added a commit to svelderrainruiz/labview-icon-editor that referenced this issue Oct 8, 2024
@svelderrainruiz svelderrainruiz moved this from Backlog to In review in Icon Editor Oct 9, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Icon Editor Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants