Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Callout: unable to close by button inside #450

Closed
Rus7am opened this issue Dec 20, 2016 · 2 comments
Closed

Callout: unable to close by button inside #450

Rus7am opened this issue Dec 20, 2016 · 2 comments

Comments

@Rus7am
Copy link
Contributor

Rus7am commented Dec 20, 2016

I'd like to be able to close a callout with uif-close attribute by clicking a button located inside uif-callout-actions component. Please see the codepen: after the Close button is clicked the ctrl.show property is being reset and the callout stays open.

I was hoping to fix this myself but everything is in TypeScript and I don't really understand it yet, sorry.

@andrewconnell
Copy link
Member

andrewconnell commented Dec 21, 2016

ATM the uif-dialog directive's functionality is very limited. This was one of the very first directives & ideally it would match the same signature and behavior the Office React version would have: https://dev.office.com/fabric#/components/dialog.

The right thing to do is to not fix this issue, rather to improve the directive to have feature parity with it's React sibling. Going to close this issue out and reference the new feature request issue 455

FWIW, we already had a discussion going on this issue: # 363

@andrewconnell
Copy link
Member

Nixing my previous comment... I got my wires crossed got uif-dialog & uif-callout backward. This appears to be a similar issue to #358 in the sense that the binding isn't being respected.

Reopening this and flagging as a bug to be investigated. I believe it's the binding defined here that's the root cause: https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/src/components/callout/calloutDirective.ts#L223-L226

Need to add a test to duplicate the bug & then resolve.

@andrewconnell andrewconnell reopened this Dec 22, 2016
@andrewconnell andrewconnell self-assigned this Dec 22, 2016
Rus7am added a commit to Rus7am/ng-officeuifabric that referenced this issue Dec 23, 2016
Fixed closing collout by clicking on button located inside it

Closes ngOfficeUIFabric#450.
Rus7am added a commit to Rus7am/ng-officeuifabric that referenced this issue Dec 26, 2016
Fixed closing collout by clicking on button located inside it

Closes ngOfficeUIFabric#450.
Rus7am added a commit to Rus7am/ng-officeuifabric that referenced this issue Dec 26, 2016
Fixed closing collout by clicking on button located inside it

Closes ngOfficeUIFabric#450.
@ghost ghost removed the waffleio:ready-for-dev label Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants