Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Feature: Create Service for Dialog #159

Closed
jigargandhi opened this issue Feb 3, 2016 · 4 comments
Closed

Feature: Create Service for Dialog #159

jigargandhi opened this issue Feb 3, 2016 · 4 comments

Comments

@jigargandhi
Copy link
Member

Dialog component on its own is of little use. Angular material provides $mdDialog service that helps in creating dialogs with various configuration.

An angular service $uifDialog needs to be created that provides functionality to create dialogs on the fly.
/cc: @andrewconnell @ngOfficeUIFabric/ngofficeuifabric-members

@jigargandhi
Copy link
Member Author

Methods

$uifDialog.alert()

$uifDialog.confirm()

$uifDialog.prompt()

$uifDialog.show()

$uifDialog.hide()

$uifDialog.cancel()

The parameters of these functions can be similar to $mdDialog

@andrewconnell: Let me know if more detailing is required /cc: @ngOfficeUIFabric/ngofficeuifabric-collaborators

@ghost ghost mentioned this issue Jun 7, 2016
@andrewconnell
Copy link
Member

IDK... I think I'd personally like to see more usage of what this would look like from a controller to be sold on this service. Then again, it's an enhancement & I get why MD has it... so if you want to tackle it, I say go for it @jigargandhi

@andrewconnell
Copy link
Member

But... need to see more of a spec before you go building so we can all agree :)

@andrewconnell
Copy link
Member

Closing... see #455

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants