Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark incomplete CARs for cleannup and removal #1562

Closed
vasco-santos opened this issue Mar 7, 2022 · 1 comment
Closed

Mark incomplete CARs for cleannup and removal #1562

vasco-santos opened this issue Mar 7, 2022 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization stack/write-services topic/upload related to uploads

Comments

@vasco-santos
Copy link
Contributor

Currently nft.storage API receives partial CAR files and stores them in S3. We are also implementing assemble-cars lambda to gather a complete CAR file from the multiple partial CARs.

Once we get complete CARs, we should look into optimizing storage by marking incomplete CARs as ready for being removed.

We also need to take into account that cnce we move to use our bucket with IPFS Elastic Provider, we also need to cleanup CID indexes before deleting the partial CARs.
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels Mar 7, 2022
@dchoi27 dchoi27 added the topic/upload related to uploads label Mar 11, 2022
@dchoi27
Copy link
Contributor

dchoi27 commented May 23, 2022

Closing given Uploads v2 approach

@dchoi27 dchoi27 closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization stack/write-services topic/upload related to uploads
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasco-santos @dchoi27