Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #8

Merged
merged 54 commits into from
Aug 27, 2024
Merged

Release 1.0.0 #8

merged 54 commits into from
Aug 27, 2024

Conversation

charles-plessy
Copy link
Collaborator

Hello,

this is the first release of the pairgenomealign pipeline!

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pairgenomealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

charles-plessy and others added 30 commits July 19, 2024 17:49
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Improve the pipeline workflow graphic/map
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
README.md Outdated Show resolved Hide resolved
@charles-plessy
Copy link
Collaborator Author

I have a couple of documentation and credit updates that I would like to make, and potential improvements to the MultiQC output. Shall I wait first for the 1.0.0 release, or can I bring the changes in via PR without invalidating the first approval ?

@mashehu
Copy link
Contributor

mashehu commented Aug 2, 2024

bring them in and ping me, so I can give you a quick second one 😉

@charles-plessy
Copy link
Collaborator Author

Hi @mashehu I have pushed three commits related to MultiQC, acknowledgements and documentation. On our side we are now ready for 1.0.0 release! (And I will be absent the next two weeks by the way).

@charles-plessy
Copy link
Collaborator Author

Hello everybody, I will be back from holidays next week. Please let me know what I can do to complete the release of the pipeline.

@mashehu
Copy link
Contributor

mashehu commented Aug 21, 2024

You can ask for a review on slack in the #request-review channel

Copy link

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to check.

subworkflows/local/pairalign_m2m/main.nf Show resolved Hide resolved
@christopher-mohr
Copy link

christopher-mohr commented Aug 26, 2024

I think someone with admin rights would also need to remove the old required check Run pipeline with test data.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charles-plessy
Copy link
Collaborator Author

Thanks! Can I press the Merge button?

@mashehu
Copy link
Contributor

mashehu commented Aug 27, 2024

an-older-man-speaking-into-a-microphone-and-saying-go-for-it

@charles-plessy charles-plessy merged commit 95a1eff into master Aug 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants