Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancer_type parameter #121

Open
bounlu opened this issue Dec 19, 2024 · 4 comments · May be fixed by #126
Open

Add cancer_type parameter #121

bounlu opened this issue Dec 19, 2024 · 4 comments · May be fixed by #126
Assignees
Labels
enhancement New feature or request

Comments

@bounlu
Copy link

bounlu commented Dec 19, 2024

It would be great to incorporate cancer_type information, if known, as a parameter into the pipeline for better biomarker identification / filtering / reporting rather than just using the generic “doid 162 cancer” here.

@bounlu bounlu added the enhancement New feature or request label Dec 19, 2024
@scwatts
Copy link
Collaborator

scwatts commented Dec 19, 2024

Thanks for opening the issue @bounlu! This has previously been discussed to some extent and an implementation planned for passing the relevant parameter to the ORANGE process that utilises existing code to collect this information from the samplesheet on a per-tumor basis

/cc @rhassaine

@bounlu
Copy link
Author

bounlu commented Dec 19, 2024

Good to know that it's already been considered in the pipeline. Can I directly use the DOIDs from here to test it in the pipeline? What are the full list of doids that are supported?

@bounlu bounlu changed the title Add cancer type parameter Add cancer_type parameter Dec 19, 2024
@rhassaine
Copy link

We have this list (for 37) @bounlu -doid.json

@bounlu
Copy link
Author

bounlu commented Dec 20, 2024

Thanks for providing the file. I have extracted the important information and simplified as a 3-column TSV file: doid.txt

@rhassaine rhassaine self-assigned this Jan 24, 2025
@rhassaine rhassaine linked a pull request Jan 29, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants