Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom config for seadragon cluster of MD Anderson Cancer Center #831

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

jiawku
Copy link
Contributor

@jiawku jiawku commented Jan 18, 2025


name: New Custom Config For Seadragon
about: A new cluster config For MD Anderson Cancer Center Seadragon Cluster

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@jfy133
Copy link
Member

jfy133 commented Jan 18, 2025

@nf-core-bot fix linting

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocker is the missing resourceLimits options rest are suggestions

conf/seadragon.config Show resolved Hide resolved
conf/seadragon.config Show resolved Hide resolved
conf/seadragon.config Outdated Show resolved Hide resolved
docs/seadragon.md Outdated Show resolved Hide resolved
docs/seadragon.md Outdated Show resolved Hide resolved
@jiawku
Copy link
Contributor Author

jiawku commented Feb 4, 2025

Hi @jfy133 , when you have time, could you please review the PR and approve it? Thank you!

conf/seadragon.config Show resolved Hide resolved
docs/seadragon.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Feb 4, 2025

Sorry @jiawku this fell off my radar!

@jfy133
Copy link
Member

jfy133 commented Feb 4, 2025

Please ping me directly here again once you've checked my changes, if you disagree that's fine and I'll give you a ✔️ and merge in

jiawku and others added 2 commits February 4, 2025 15:54
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
@jiawku
Copy link
Contributor Author

jiawku commented Feb 4, 2025

Hi James @jfy133, I have committed the changes you suggested, and it's ready to be merged. Thank you so much!

@jfy133 jfy133 self-requested a review February 6, 2025 08:29
@jfy133 jfy133 merged commit 8deadb3 into nf-core:master Feb 6, 2025
110 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants