-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the daisybio profile #737
Update for the daisybio profile #737
Conversation
…/configs into update_daisybio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only thing is the keep_work profile might not be necessary as nf-core comes with one my default called debug (https://github.com/nf-core/tools/blob/master/nf_core%2Fpipeline-template%2Fnextflow.config#L88-L93)
But it comes with extra bells and whistles you might not want, so up to you
Thanks for the review! I am aware of the debug option, but afaik will also produce more verbose logging, etc. |
name: daisybio
about: Update for the daisybio profile
New additions:
Please follow these steps before submitting your PR:
[WIP]
in its titlemaster
branchSteps for adding a new config profile:
conf/
directorydocs/
directorynfcore_custom.config
file in the top-level directoryREADME.md
file in the top-level directoryprofile:
scope in.github/workflows/main.yml