Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXmx: should NXdetector_channel in NXdetector be required? #1511

Closed
spc93 opened this issue Nov 14, 2024 · 2 comments · Fixed by #1535
Closed

NXmx: should NXdetector_channel in NXdetector be required? #1511

spc93 opened this issue Nov 14, 2024 · 2 comments · Fixed by #1535
Assignees

Comments

@spc93
Copy link

spc93 commented Nov 14, 2024

This field probably doesn't make sense in many types of detector so would it be better to make it optional to avoid adding meaningless values or giving a validation error?

@phyy-nx
Copy link
Contributor

phyy-nx commented Jan 16, 2025

Telco: this looks like a bug. Will check with dectris then add recommended=True.

@phyy-nx phyy-nx self-assigned this Jan 16, 2025
@soph-dec
Copy link
Contributor

Agreed, it makes no sense that this field is required, this is a bug. I think making it optional is enough though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants