-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Limit preview sizes and scale from closest match #11722
Comments
cc @rullzer |
This one is tricky. Because there are so many factors to consider.
So that are 3 different sizes. All fine.
We generate a 'master' preview from which we scale already. Also we do round up to the nearest power of 2 for previews. However this of course still leaves a lot of previews. |
@rullzer You are of course correct. I will assume that there different use cases and in that regard a custom setting for this would be very useful. Examples
So an option to specify what sizes that should be generated would probably be very beneficial for many users. Also, png's might be a better choice for really small dimensions. This could be an additional option. Thank you. |
Would love to see this implemented as well. Using default nextcloudpi config, I have 13GB of previews from a 28GB account, which also means my backups take a long time to run and themselves are 13GB in size without compression! 😱 |
Additionally, if the browser requests say a 130pixel thumbnail you'll get a 1024pixel image ... |
@rullzer I'm going out on a limb here, I think people care a little less about the exact resolution of the thumbnail and care more about web page performance and disk usage, there's the bug in #13709 (comment) ... in other words, if someone gets a little lower resolution thumbnail, but everything is FAST and doesnt chew up much disk, no one will care |
Please use the recommended settings from this article which will limit the numbers of previews that get generated. |
The link provided as an answer is broken. |
I ran the steps below to see which actions generated which previews. This test was done with a landscape-oriented photo.
@rullzer I understand we need several sizes, but my test above brings these questions:
|
Currently, Nextcloud can generate several different previews of different sizes for the same file. This depends on for example, what client is used.
Eventually this will eat up a lot of storage space and server resources.
So my feature request is:
I know it is possible to use previewgenerator and also to lower its jpeg quality to save space, but it isn't enough. Also, generating a small preview takes much more time than sending a slightly larger file and let the client's browser scale it down.
The text was updated successfully, but these errors were encountered: