Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete a vault #826

Open
DaGo1120 opened this issue Dec 30, 2024 · 3 comments
Open

Cannot delete a vault #826

DaGo1120 opened this issue Dec 30, 2024 · 3 comments
Labels

Comments

@DaGo1120
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Opening a vault using the correct credentials
  2. I see an empty vault (this is correct, I haven't added any passwords)
  3. Going to the Settings (Don't know the exact translation, it is "Einstellungen" in german)
  4. in common settings tab ("Allgemeine Einstellungen" in german), section delete vault ("Tresor löschen"), I enter my password again, set the check box to confirm the deletion of all passwords and hitting the button to execute the deletion

Expected behaviour

I would have expected a confirmation and the vault should be deleted.

Actual behaviour

Nothing happens, the vault still exists.

Server configuration

Web server: Apache

Database: Maria

PHP version: 8.3 (but same behavior with previous installed 8.1)

Nextcloud version: 30.0.4

Nextcloud log /nextcloud.log
{"reqId":"ki3aqL0gcPtE3yYWseRe","level":3,"time":"2024-12-30T08:10:32+00:00","remoteAddr":"192.168.1.2","user":"daniel","app":"index","method":"DELETE","url":"/nextcloud/index.php/apps/passman/api/v2/vaults/C460523D-6EDE-4681-8701-A1B69035D166","message":"OC\\DB\\QueryBuilder\\QueryBuilder::prefixTableName(): Argument #1 ($table) must be of type string, null given, called in /var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php on line 1335 in file '/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php' line 1345","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0","version":"30.0.4.1","exception":
    {"Exception":"Exception","Message":"OC\\DB\\QueryBuilder\\QueryBuilder::prefixTableName(): Argument #1 ($table) must be of type string, null given, called in /var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php on line 1335 in file '/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php' line 1345","Code":0,"Trace":[
        {"file":"/var/www/html/nextcloud/lib/private/AppFramework/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},
        {"file":"/var/www/html/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},
        {"file":"/var/www/html/nextcloud/lib/base.php","line":1003,"function":"match","class":"OC\\Route\\Router","type":"->"},
        {"file":"/var/www/html/nextcloud/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","Line":146,"Previous":
        {"Exception":"TypeError","Message":"OC\\DB\\QueryBuilder\\QueryBuilder::prefixTableName(): Argument #1 ($table) must be of type string, null given, called in /var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php on line 1335","Code":0,"Trace":[
            {"file":"/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":1335,"function":"prefixTableName","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},
            {"file":"/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":623,"function":"getTableName","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},
            {"file":"/var/www/html/nextcloud/apps/passman/lib/Service/NotificationService.php","line":117,"function":"delete","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},
            {"file":"/var/www/html/nextcloud/apps/passman/lib/Service/CredentialService.php","line":124,"function":"deleteNotificationsOfCredential","class":"OCA\\Passman\\Service\\NotificationService","type":"->"},
            {"file":"/var/www/html/nextcloud/apps/passman/lib/Controller/VaultController.php","line":175,"function":"deleteCredentialParts","class":"OCA\\Passman\\Service\\CredentialService","type":"->"},
            {"file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":208,"function":"delete","class":"OCA\\Passman\\Controller\\VaultController","type":"->"},
            {"file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":114,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},
            {"file":"/var/www/html/nextcloud/lib/private/AppFramework/App.php","line":161,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},
            {"file":"/var/www/html/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},
            {"file":"/var/www/html/nextcloud/lib/base.php","line":1003,"function":"match","class":"OC\\Route\\Router","type":"->"},
            {"file":"/var/www/html/nextcloud/index.php","line":24,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","Line":1345
        },"message":"OC\\DB\\QueryBuilder\\QueryBuilder::prefixTableName(): Argument #1 ($table) must be of type string, null given, called in /var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php on line 1335 in file '/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php' line 1345","exception":{},"CustomMessage":"OC\\DB\\QueryBuilder\\QueryBuilder::prefixTableName(): Argument #1 ($table) must be of type string, null given, called in /var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php on line 1335 in file '/var/www/html/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php' line 1345"
    }
}
List of activated apps
Enabled:
  - activity: 3.0.0
  - app_api: 4.0.3
  - bruteforcesettings: 3.0.0
  - calendar: 5.0.8
  - circles: 30.0.0
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.2
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_downloadlimit: 3.0.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - firstrunwizard: 3.0.0
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - nextcloud_announcements: 2.0.0
  - notifications: 3.0.0
  - oauth2: 1.18.1
  - passman: 2.4.11
  - password_policy: 2.0.0
  - photos: 3.0.2
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - recommendations: 3.0.0
  - related_resources: 1.5.0
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - spreed: 20.1.1
  - support: 2.0.0
  - survey_client: 2.0.0
  - systemtags: 1.20.0
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - updatenotification: 1.20.0
  - user_status: 1.10.0
  - viewer: 3.0.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - admin_audit: 1.20.0
  - encryption: 2.18.0
  - files_external: 1.22.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - suspicious_login: 8.0.0
  - twofactor_nextcloud_notification: 4.0.0
  - twofactor_totp: 12.0.0-dev
  - user_ldap: 1.21.0
Nextcloud configuration
{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "192.168.1.216",
            "***REMOVED SENSITIVE VALUE***",
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "30.0.4.1",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_sendmailmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "maintenance_window_start": 1
    }
}

Browser

Browser name: Firefox

Browser version: 133.0.3 (64-Bit)

Operating system: Ubuntu 24.04.1 LTS

@DaGo1120 DaGo1120 added the bug label Dec 30, 2024
@OS3DrNick
Copy link
Collaborator

Seems like a bug indeed, didnt test that one for a long time.

Is it possible to delete the vault via the request destruction procedure?

Home -> Select Vault -> Forgot Password -> Ask for vault Destruction?
And then (as Admin) User icon -> Admin Settings -> (at the bottom) Additional Settings -> Passman -> Vault Destruction Requests?

@DaGo1120
Copy link
Author

Seems like a bug indeed, didnt test that one for a long time.

Is it possible to delete the vault via the request destruction procedure?

Home -> Select Vault -> Forgot Password -> Ask for vault Destruction? And then (as Admin) User icon -> Admin Settings -> (at the bottom) Additional Settings -> Passman -> Vault Destruction Requests?

Thank you! Yes, this works for me as a workaround.
Does the error in the nextcloud.log (see above) matter? Or do I not need to pay any further attention to this?

@binsky08
Copy link
Collaborator

Thanks for the report, I was able to reproduce the bug.
The exception in the nextcloud.log you noticed, is indeed the error produced by this bug.
I'll try to look a bit deeper into it the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants