Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0.0-alpha] - NcDateTimePicker behaves different #5950

Closed
dartcafe opened this issue Aug 10, 2024 · 9 comments
Closed

[9.0.0-alpha] - NcDateTimePicker behaves different #5950

dartcafe opened this issue Aug 10, 2024 · 9 comments
Assignees
Labels
2. developing Work in progress bug Something isn't working feature: datepicker Related to the date/time picker component vue 3 Related to the vue 3 migration

Comments

@dartcafe
Copy link
Contributor

dartcafe commented Aug 10, 2024

Previously I could select a date and confirm the choice with an OK button.
The 9.0.0-alpha.5 variant closes the popup upon clicking on a date.

Version 8Version 9
8.mp4
9.mp4

IMHO it should behave like before

@ShGKme ShGKme added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: datepicker Related to the date/time picker component vue 3 Related to the vue 3 migration labels Aug 10, 2024
@susnux
Copy link
Contributor

susnux commented Aug 14, 2024

Yes I also agree, this is a bug.

@dartcafe
Copy link
Contributor Author

@susnux Any change to fix that for the next release (alpha-6)? It still breaks the UX of Polls significantly.

@ShGKme ShGKme self-assigned this Jan 25, 2025
@ShGKme ShGKme added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 25, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Jan 25, 2025

Cannot reproduce in docs. Checking in Polls.

@ShGKme

This comment has been minimized.

@dartcafe

This comment has been minimized.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2025

Component requires confirmation only with confirm prop.

See "Example with confirm button". You need to add confirm: true.

https://nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepicker

@dartcafe
Copy link
Contributor Author

OMFG. Are you kidding???? 🤣

Is this new? I did not recognize any change regarding this setting. Anyway. Thanks for the help, this seems to work now. Now I have to find out, why the time span is not created properly.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 27, 2025

Is this new?

I'm not sure, but it is the same in v8...

@ShGKme ShGKme closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
@dartcafe
Copy link
Contributor Author

dartcafe commented Feb 1, 2025

Yes, True. And now I know, why I did not use it. I don't get proper information about the modelValue while picking dates, but I need it to be able to display the preview of the result.

Anyway, the behavior is still strange without confirmation: true. I get the values in a wrong order, but could not debug it deep enough. And there is the OK button, I don't need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feature: datepicker Related to the date/time picker component vue 3 Related to the vue 3 migration
Projects
None yet
Development

No branches or pull requests

3 participants