Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bump workflow doesn't calculate the version retroactively #464

Open
2 tasks
rmanaem opened this issue Jan 29, 2025 · 6 comments
Open
2 tasks

version bump workflow doesn't calculate the version retroactively #464

rmanaem opened this issue Jan 29, 2025 · 6 comments
Assignees

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Jan 29, 2025

It only uses the PR that releases the tool see:

Relevant commit: 751d981

It's respective workflow run: https://github.com/neurobagel/query-tool/actions/runs/13036084018/job/36366735131

TODO:

  • find out why it is not looking at the other PRs
  • change the wf so it computes the correct version by considering all previous PRs since the last release
@rmanaem rmanaem added the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 29, 2025
@rmanaem rmanaem moved this to Backlog in Neurobagel Jan 31, 2025
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 31, 2025
@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Feb 17, 2025
@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Feb 17, 2025
@surchs surchs moved this from Specify - Done to Implement - Active in Neurobagel Feb 17, 2025
@surchs surchs self-assigned this Feb 17, 2025
@surchs
Copy link
Contributor

surchs commented Feb 18, 2025

Trying things out in #464, so far no luck. Probably should either open an issue or post on stackoverflow

@alyssadai
Copy link
Contributor

alyssadai commented Feb 18, 2025

@surchs, I know you mentioned trying some variants using the --dry-run option, but maybe this could be helpful?

intuit/auto#1490 (comment)

(also, did you mean to link a PR instead of this issue? :)

@surchs
Copy link
Contributor

surchs commented Feb 18, 2025

(also, did you mean to link a PR instead of this issue? :)

oh boy, that's worrying. Yes indeed I tried to to do that #490

@surchs
Copy link
Contributor

surchs commented Feb 18, 2025

Aha, yes indeed this was very useful, thanks @alyssadai. I learned that the canary release doesn't actually work:

⚠  warning   None of the plugins that you are using implement the `canary` command!

https://github.com/neurobagel/query-tool/actions/runs/13399686305/job/37427265986?pr=490#step:7:14

@surchs
Copy link
Contributor

surchs commented Feb 19, 2025

So we tried a lot of things on this issue. Our best guess is that we would need to use auto shipit --dry-run. However, auto does this thing called "context aware publishing" where it makes a canary release when run on a PR branch (as we are): https://intuit.github.io/auto/docs/generated/shipit

And as the error message above says, we can't make canary releases because of a plugin issue. So far it's not clear whether we are

  • missing a plugin that enables canary
  • have a plugin that is incompatible with canary

We tried removing plugins from the .autorc and the error message about canary stayed around. So most likely we are missing a plugin.

At this point the next step is to either

  • open an issue / discussion on their GitHub
  • ask on stackoverflow
  • explore switching to a different tool that computes semver from labels (or maybe even does the release as well)

@surchs surchs added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Feb 19, 2025
@surchs surchs moved this from Implement - Active to Implement - Track in Neurobagel Feb 19, 2025
@surchs
Copy link
Contributor

surchs commented Feb 20, 2025

We'll keep this issue open an in tracked until we have an answer from opening an issue against auto or a post on stackoverflow

@rmanaem rmanaem removed the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Implement - Track
Development

No branches or pull requests

3 participants