From a3a7782981cef3ff930a2a862220d0e906d002ae Mon Sep 17 00:00:00 2001 From: Sebastian Urchs Date: Tue, 19 Mar 2024 14:35:48 -0400 Subject: [PATCH] Try this one more time --- .github/pull_request_template.md | 11 ++++++++--- .github/workflows/build_docker_on_release.yml | 12 ++++-------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f99181b2..849cb1ae 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,32 +1,35 @@ - - + - Closes # - + Changes proposed in this pull request: - - + ## Checklist + _This section is for the PR reviewer_ - [ ] PR has an interpretable title with a prefix (`[ENH]`, `[FIX]`, `[REF]`, `[TST]`, `[CI]`, `[MNT]`, `[INF]`, `[MODEL]`, `[DOC]`) _(see our [Contributing Guidelines](https://neurobagel.org/contributing/CONTRIBUTING#pull-request-guidelines) for more info)_ @@ -36,7 +39,9 @@ _This section is for the PR reviewer_ - [ ] Checks pass For new features: + - [ ] Tests have been added For bug fixes: + - [ ] There is at least one test that would fail under the original bug conditions. diff --git a/.github/workflows/build_docker_on_release.yml b/.github/workflows/build_docker_on_release.yml index 8cf98939..74cf1df4 100644 --- a/.github/workflows/build_docker_on_release.yml +++ b/.github/workflows/build_docker_on_release.yml @@ -8,20 +8,16 @@ jobs: build: runs-on: ubuntu-latest steps: - - - name: Checkout + - name: Checkout uses: actions/checkout@v4 - - - name: Login to Docker Hub + - name: Login to Docker Hub uses: docker/login-action@v3 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} - - - name: Set up Docker Buildx + - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - - - name: Build and push + - name: Build and push uses: docker/build-push-action@v5 with: context: .