Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create updated compatibility tests of tools that will run on PRs #253

Open
6 tasks
alyssadai opened this issue Feb 13, 2025 · 0 comments
Open
6 tasks

Create updated compatibility tests of tools that will run on PRs #253

alyssadai opened this issue Feb 13, 2025 · 0 comments
Labels
Milestone Used to track other issues that are required to complete the milestone.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Feb 13, 2025

Context

As we start having more nodes in our network that are maintained by others, and also we are hosting more services, it becomes increasingly important to make sure that we are intentional about introducing breaking changes and have plans in place on how to deal with them. The first step here is to make sure that we know if we are about to unintentionally introduce a breaking change, and then not do that.

Why

We have an existing simple compatibility test that runs on a cronjob and checks that all nightly tools and latest tools do not produce errors when launched using our full stack recipe.

However, to avoid releasing breaking changes unintentionally that will result in an incompatible deployment or break our public services, we should have a test that runs before changes are merged (i.e., on PRs) that will signal to us if we are safe to release the change or not.

Outcomes

  • We have compatibility tests that run:
    • automatically on PRs
      • once with the PR branch version of tool + latest of all others, to give a signal if it’s safe to release after/on PR merge
      • once with PR branch version of tool + nightly of all others
    • once a day / on some cronjob, with all latest versions as a sanity check
      • if this passes, should ideally write current (confirmed) versions of tools to a file
  • For now, the tests will run on the GH runner, and internally spin up a stack including all services (deployment recipe + CLI)
  • Eventually, we want to move the tool stack that tests will run on to a staging area

What

  • [ ]
@alyssadai alyssadai added the Milestone Used to track other issues that are required to complete the milestone. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Milestone Used to track other issues that are required to complete the milestone.
Projects
Status: No status
Development

No branches or pull requests

1 participant