Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Page Refactor for Phase 2 Store Refactor #347

Closed
7 tasks done
Tracked by #305
jarmoza opened this issue Feb 6, 2023 · 6 comments
Closed
7 tasks done
Tracked by #305

Annotation Page Refactor for Phase 2 Store Refactor #347

jarmoza opened this issue Feb 6, 2023 · 6 comments
Assignees
Labels
annotation page Epic A collection of issues that are related by topic and can be addressed together. refactor Simplifying or restructuring existing code or documentation.

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Feb 6, 2023

Now that we are into the second phase of the store refactor - moving onto the annotation and download pages - it will be necessary to refactor the annotation page itself before its dependent components can be fully tested manually and via our page-level e2e tests for the page.

Below is a list of the refactor work that needs to be done to the annotation page:

Once this work is complete, then the e2e test for the annotation can be re-enabled for the github testing workflow. At this point, the e2e tests for the annotation page will likely need to be updated as well:

@jarmoza jarmoza added annotation page maintenance:coverage refactor Simplifying or restructuring existing code or documentation. labels Feb 6, 2023
@github-project-automation github-project-automation bot moved this to Inbox in Neurobagel Feb 6, 2023
@jarmoza jarmoza moved this from Inbox to Blocked in Neurobagel Feb 6, 2023
@jarmoza jarmoza moved this from Blocked to Doing in Neurobagel Mar 7, 2023
@jarmoza
Copy link
Contributor Author

jarmoza commented Mar 7, 2023

In light of the possible complexity of this page refactor, I will spin off this work into several PRs.

@jarmoza
Copy link
Contributor Author

jarmoza commented Apr 4, 2023

Blocked by #386

@rmanaem rmanaem removed this from Neurobagel Apr 12, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label May 5, 2023
@surchs
Copy link
Contributor

surchs commented May 8, 2023

This seems to be unblocked / finished. @jarmoza / @rmanaem could you check + close?

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label May 9, 2023
@rmanaem
Copy link
Contributor

rmanaem commented May 10, 2023

I believe this is finished @jarmoza could you confirm?

@jarmoza
Copy link
Contributor Author

jarmoza commented May 10, 2023

@surchs / @rmanaem Confirmed. Closed.

@jarmoza jarmoza closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page Epic A collection of issues that are related by topic and can be addressed together. refactor Simplifying or restructuring existing code or documentation.
Projects
None yet
Development

No branches or pull requests

3 participants