Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add new, custom categories to category select table #228

Open
jarmoza opened this issue Nov 14, 2022 · 6 comments
Open

Ability to add new, custom categories to category select table #228

jarmoza opened this issue Nov 14, 2022 · 6 comments
Labels
categorization page someday Not a priority right now, but we want to keep this around to think or discuss more.

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Nov 14, 2022

Expectations

Add a new category (assessment tool group for now)
click on a plus icon to start the process
new UI element appears with a default name, I can click on it to enter / change its name
I can click an "x" icon (or similar) to delete the category (assessment tool group) again.
clicking on the new category makes it the selected category (i.e. I can now "tag" columns with this category)

Required input:

list categories for selection
has some way of knowing whether a category is user-defined / editable / deleteable.
This will control whether user can change name / delete the category and whether the corresponding UI elements exist
css classes for each category - for opacity and color

Generated output:

currently selected category (sent up to categorization page)
created (new) category (assessment tool group)
deleted category (assessment tool group)

Further Notes

This particular addition has a few ins and outs that I will document here.

The plus icon should be set at the bottom of the category select table and move down as categories are added
The UI element to appear for name addition can either be an editable row or a separate component. The problem with the former is that editing vs selecting may be incompatible (either to b-table or just in general from a UX perspective
Clicking the 'X' icon deletes only custom categories. Presumably we don't want the user to have the ability to delete original categories (as defined now in the store, and in the future, as defined in the app config file. So X's will only appear next to custom categories.
Deleting a category necessarily de-links the columns of the data table with that category
Additional categories will need to choose colors from a palette. For now they will all be the same color
There's the question of whether or not these new, custom categories behave like (or replace) the "Assessment Tool" category

Design notes for editable custom category name feature:

Editable textbox featuring name of currently selected category (grey for original categories)
Editing name searches through columnToCategoryMap in store and edits name of category assigned to each column

@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 29, 2022
@jarmoza jarmoza removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 5, 2023
@jarmoza jarmoza removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 7, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 11, 2023
@surchs surchs removed the status in Neurobagel Mar 21, 2023
@surchs surchs moved this to Backlog in Neurobagel Mar 21, 2023
@surchs surchs removed the status in Neurobagel Apr 19, 2023
@surchs
Copy link
Contributor

surchs commented Jun 6, 2023

@jarmoza just like #227 I think this is quite stale and not near the top of the pile. I'd vote to close and then revisit once we actually are thinking about getting to doing this. wdyt?

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jun 7, 2023
@surchs surchs removed this from Neurobagel Jun 7, 2023
@surchs surchs closed this as completed Jun 10, 2023
@jarmoza
Copy link
Contributor Author

jarmoza commented Jun 12, 2023

@surchs So given our discussions last week about keeping issues around that we know will be worked on but we're not sure as of yet when, is closing this issue in line with that?

I'm fine with that. Obviously we know that this is currently a recurrent ask from JB so it's in our heads, but I'm wondering if closing this ends up hiding the issue – and doing so in other instances would hide issues/ideas/features that are less at the front of our mind.

And in the cases of #221 and #227, these could be thought of as being subtasks of this custom category issue. So closing them now is less of an issue re: last week's discussion.

@surchs
Copy link
Contributor

surchs commented Jun 12, 2023

thanks for catching that @jarmoza. Agreed, I shouldn't have closed. These are now going to remain as feature requests to be prioritized / voted on (https://github.com/neurobagel/project/issues/132)

@surchs surchs added the someday Not a priority right now, but we want to keep this around to think or discuss more. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categorization page someday Not a priority right now, but we want to keep this around to think or discuss more.
Projects
None yet
Development

No branches or pull requests

2 participants