-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add new, custom categories to category select table #228
Comments
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. |
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. |
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. |
@surchs So given our discussions last week about keeping issues around that we know will be worked on but we're not sure as of yet when, is closing this issue in line with that? I'm fine with that. Obviously we know that this is currently a recurrent ask from JB so it's in our heads, but I'm wondering if closing this ends up hiding the issue – and doing so in other instances would hide issues/ideas/features that are less at the front of our mind. And in the cases of #221 and #227, these could be thought of as being subtasks of this custom category issue. So closing them now is less of an issue re: last week's discussion. |
thanks for catching that @jarmoza. Agreed, I shouldn't have closed. These are now going to remain as feature requests to be prioritized / voted on (https://github.com/neurobagel/project/issues/132) |
Expectations
Add a new category (assessment tool group for now)
click on a plus icon to start the process
new UI element appears with a default name, I can click on it to enter / change its name
I can click an "x" icon (or similar) to delete the category (assessment tool group) again.
clicking on the new category makes it the selected category (i.e. I can now "tag" columns with this category)
Required input:
list categories for selection
has some way of knowing whether a category is user-defined / editable / deleteable.
This will control whether user can change name / delete the category and whether the corresponding UI elements exist
css classes for each category - for opacity and color
Generated output:
currently selected category (sent up to categorization page)
created (new) category (assessment tool group)
deleted category (assessment tool group)
Further Notes
This particular addition has a few ins and outs that I will document here.
The plus icon should be set at the bottom of the category select table and move down as categories are added
The UI element to appear for name addition can either be an editable row or a separate component. The problem with the former is that editing vs selecting may be incompatible (either to b-table or just in general from a UX perspective
Clicking the 'X' icon deletes only custom categories. Presumably we don't want the user to have the ability to delete original categories (as defined now in the store, and in the future, as defined in the app config file. So X's will only appear next to custom categories.
Deleting a category necessarily de-links the columns of the data table with that category
Additional categories will need to choose colors from a palette. For now they will all be the same color
There's the question of whether or not these new, custom categories behave like (or replace) the "Assessment Tool" category
Design notes for editable custom category name feature:
Editable textbox featuring name of currently selected category (grey for original categories)
Editing name searches through columnToCategoryMap in store and edits name of category assigned to each column
The text was updated successfully, but these errors were encountered: