Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_control=False always returns no results #128

Closed
1 task done
alyssadai opened this issue Oct 24, 2024 · 1 comment · Fixed by #129
Closed
1 task done

is_control=False always returns no results #128

alyssadai opened this issue Oct 24, 2024 · 1 comment · Fixed by #129
Assignees
Labels
released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Oct 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behavior

No response

Current Behavior

Since the n-API doesn't have logic yet in the SPARQL query template to filter for non-healthy control subjects only (i.e., subjects without the nb:hasSubjectGroup property), we should disallow setting is_control=False in the f-API as well since at the moment this will always return no matches.

Specifically, since PR neurobagel/api#364, is_control=False will produce node-level validation errors. We should update this query param in the f-API to also accept (and pass on) strings and do basic validation (since this is a non-intuitive constraint).

Error message

No response

Environment

  • OS:
  • Python/Node version:

How to reproduce

No response

Anything else?

No response

@alyssadai alyssadai moved this to Implement - Done in Neurobagel Oct 24, 2024
@alyssadai alyssadai self-assigned this Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Oct 24, 2024
Copy link
Contributor

🚀 Issue was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant