Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subdirectory root paths when API is behind a proxy #392

Closed
2 tasks done
alyssadai opened this issue Dec 17, 2024 · 1 comment · Fixed by #400
Closed
2 tasks done

Support subdirectory root paths when API is behind a proxy #392

alyssadai opened this issue Dec 17, 2024 · 1 comment · Fixed by #400
Assignees
@alyssadai
Labels
released This issue/pull request has been released. usability Issue affecting user or developer experience.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 17, 2024 •
edited
Loading

Currently, even when a reverse proxy is set up to strip a path prefix, the interactive docs /docs path won't work because the docs UI requires the OpenAPI schema to declare what the proxied server URL is (see https://fastapi.tiangolo.com/advanced/behind-a-proxy/#proxy-with-a-stripped-path-prefix).

Steps to implement

Is there an easy way to test this?
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 17, 2024
@rmanaem rmanaem moved this to Backlog in Neurobagel Jan 6, 2025
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 6, 2025
@alyssadai alyssadai moved this from Backlog to Specify - Active in Neurobagel Jan 7, 2025
@alyssadai alyssadai moved this from Specify - Active to Specify - Done in Neurobagel Jan 7, 2025
@alyssadai alyssadai added the usability Issue affecting user or developer experience. label Jan 7, 2025
@alyssadai alyssadai moved this from Specify - Done to Implement - Active in Neurobagel Jan 7, 2025
@alyssadai alyssadai self-assigned this Jan 7, 2025
This was referenced Jan 8, 2025
Merged
Closed
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Jan 8, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Jan 18, 2025
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Feb 7, 2025

🚀 Issue was released in v0.6.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
released This issue/pull request has been released. usability Issue affecting user or developer experience.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Make root_path for app configurable neurobagel/api
2 participants
@alyssadai @rmanaem