Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old default values for ENV variables #356

Closed
surchs opened this issue Oct 16, 2024 · 1 comment · Fixed by #400
Closed

Replace old default values for ENV variables #356

surchs opened this issue Oct 16, 2024 · 1 comment · Fixed by #400
Assignees
@alyssadai
Labels
quick fix Minimal planning and/or implementation work required. refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented Oct 16, 2024

We have some old / outdated default values for unset ENV variables:

api/app/api/utility.py

Lines 26 to 32 in a17eda8

GRAPH_ADDRESS = EnvVar(
"NB_GRAPH_ADDRESS", os.environ.get("NB_GRAPH_ADDRESS", "206.12.99.17")
)
GRAPH_DB = EnvVar(
"NB_GRAPH_DB", os.environ.get("NB_GRAPH_DB", "test_data/query")
)
GRAPH_PORT = EnvVar("NB_GRAPH_PORT", os.environ.get("NB_GRAPH_PORT", 5820))

Specifically:

  • NB_GRAPH_ADDRESS (should be localhost or something else) and
  • NB_GRAPH_PORT (should be 7200 since GraphDB)

This probably hasn't caused any issues because we deploy via docker-compose where these values are actively set to their correct defaults:

https://github.com/neurobagel/recipes/blob/7b8669530569a5e69f03b740d53373cafec4d1e8/docker-compose.yml#L11-L19

But we should change them anyhow.
@surchs surchs added refactor Simplifying or restructuring existing code or documentation. type:maintenance quick fix Minimal planning and/or implementation work required. labels Oct 16, 2024
@alyssadai alyssadai moved this to Implement - Active in Neurobagel Jan 8, 2025
@alyssadai alyssadai mentioned this issue Jan 8, 2025
Merged
8 tasks
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Jan 8, 2025
@alyssadai alyssadai self-assigned this Jan 9, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Jan 18, 2025
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Feb 7, 2025

🚀 Issue was released in v0.6.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
quick fix Minimal planning and/or implementation work required. refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Make root_path for app configurable neurobagel/api
2 participants
@surchs @alyssadai