Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update num_{imaging,phenotypic}_sessions to be num_matching_{imaging,phenotypic}_sessions #271

Closed
3 tasks done
Tracked by #83
alyssadai opened this issue Jan 29, 2024 · 1 comment · Fixed by #282
Closed
3 tasks done
Tracked by #83
Assignees
Labels
released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Jan 29, 2024

The query result for a given subject currently looks like this:

      {
        "sub_id": "sub-03",
        "session_id": "ses-02",
        "num_phenotypic_sessions": 1,
        "num_imaging_sessions": 2,
        "session_type": "http://neurobagel.org/vocab/PhenotypicSession",
        "age": 23.2,
        "sex": null,
        "diagnosis": [
          "http://purl.bioontology.org/ontology/SNOMEDCT/406506008"
        ],
        "subject_group": null,
        "assessment": [
          "https://www.cognitiveatlas.org/task/id/trm_57964b8a66aed",
          "https://www.cognitiveatlas.org/task/id/tsk_4a57abb949ece"
        ],
        "image_modal": [
          null
        ],
        "session_file_path": null
      },

However, the number of phenoypic and imaging sessions are not actually the total # sessions, but the sessions matching the query. We should clarify this in the result to avoid confusion.

Steps to implement

  • Update the query response model
  • Update the default query file
  • Update the query template
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 29, 2024
@surchs surchs moved this to Backlog in Neurobagel Jan 29, 2024
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 29, 2024
@alyssadai alyssadai moved this from Backlog to Specify - Active in Neurobagel Feb 12, 2024
@alyssadai alyssadai moved this from Specify - Active to Implement - Active in Neurobagel Feb 13, 2024
@alyssadai alyssadai self-assigned this Feb 13, 2024
@alyssadai alyssadai moved this from Implement - Active to Implement - Track in Neurobagel Feb 15, 2024
@alyssadai alyssadai moved this from Implement - Track to Implement - Active in Neurobagel Feb 22, 2024
@alyssadai alyssadai changed the title num_{imaging,phenotypic}_sessions should be num_matching_{imaging,phenotypic}_sessions? Update num_{imaging,phenotypic}_sessions to be num_matching_{imaging,phenotypic}_sessions Feb 28, 2024
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Feb 28, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Feb 28, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Feb 28, 2024
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 Issue was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants