Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss store structure #55

Open
rmanaem opened this issue Feb 24, 2025 · 0 comments
Open

Discuss store structure #55

rmanaem opened this issue Feb 24, 2025 · 0 comments
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Feb 24, 2025

Is it really necessary to have dataTable, columns, uploadedDataTableFileName to all be separate store variables? I understand the benefit of avoiding deep updates, but all of these things are very closely releated, so representing them in a single object would make sense, no? If this is a big change, please make an issue to discuss instead.

Originally posted by @surchs in #50 (comment)
@rmanaem rmanaem added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Feb 24, 2025
@rmanaem rmanaem mentioned this issue Feb 24, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmanaem