Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run samples tests in CI #3177

Closed
BrunnerLivio opened this issue Oct 14, 2019 · 1 comment
Closed

Run samples tests in CI #3177

BrunnerLivio opened this issue Oct 14, 2019 · 1 comment
Labels

Comments

@BrunnerLivio
Copy link
Member

BrunnerLivio commented Oct 14, 2019

Feature Request

Is your feature request related to a problem? Please describe.

Currently samples are being built in CI, but not tested. To further strengthen the tests of NestJS we should automatically test sample test against the built NestJS code.

Describe the solution you'd like

The CI should check for each sample whether npm run test and npm run test:e2e is defined. If one of these commands is available, it should run these tests with the built NestJS code.

Track how long the CI task will run for. Currently Build all samples takes around 10 minutes. Since this issue will further extend this task, we may should investigate in paralleling the build (one build & test task per sample) or try other approaches (investigate more into caching).

Related issue #3173 #1539

@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants