Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency: calculated daily Tx Fee vs the charted one #1855

Open
phroi opened this issue Jan 22, 2025 · 9 comments
Open

Inconsistency: calculated daily Tx Fee vs the charted one #1855

phroi opened this issue Jan 22, 2025 · 9 comments
Assignees

Comments

@phroi
Copy link
Contributor

phroi commented Jan 22, 2025

Hello Explorer Folk,

looking at the tx fee chart, explained as Total transaction fees charged by miners, I noticed a spike of almost 500k CKB in fees on the 2024/7/31. Removing the logarithm scale makes it evident how much of an outlier it really is.

So I went to calculate it manually using txs_fee in get_block_economic_state for each block in that day and I got:

Basically I'm unable to reproduce the Explorer chart results.

Could you explain the inconsistency ?

Love & Peace, Phroi

@phroi phroi changed the title Inconsistency: daily Tx Fee calculated vs the carted one Inconsistency: calculated daily Tx Fee vs the charted one Jan 22, 2025
@Keith-CY Keith-CY self-assigned this Jan 23, 2025
@Keith-CY
Copy link
Collaborator

Hi @phroi thank you for sharing this.

@poor-defined do you have time for this case?

@poor-defined
Copy link

Hi @phroi thank you for sharing this.

@poor-defined do you have time for this case?

Yes, I will check it.

@poor-defined
Copy link

Hi @phroi ,
We found that in block 13653520, a transaction paid a significant transfer fee, leading to such a peak in tx fee chart.

cc @Keith-CY

@phroi
Copy link
Contributor Author

phroi commented Jan 23, 2025

Man, these days people don't really know how to spend their CKB!! 🤣

@poor-defined good to know, thank you!! By the way, that tx did not appear in my data because is date on 2024/08/01 21:33:19, definitely didn't happen on the 2024/07/31.

Could you explain why is it charted under the 2024/07/31?

@phroi
Copy link
Contributor Author

phroi commented Jan 23, 2025

Image

@poor-defined
Copy link

Man, these days people don't really know how to spend their CKB!! 🤣

@poor-defined good to know, thank you!! By the way, that tx did not appear in my data because is date on 2024/08/01 21:33:19, definitely didn't happen on the 2024/07/31.

Could you explain why is it charted under the 2024/07/31?

Yep, crazy, man.

And about the date issue, I believe this is a mistake caused by time scaling as you can see on the x-axis.

There're too many dates on the x-axis ,so the x-axis is compressed. The displayed date when you hover your mouse is not the exact date of the Transaction Fee. I think the displayed date without zooming in is just included the date period where the maximum value occurred but not the exact day of when it happens.

If we narrow the range on x-axis, we can see this value positioned correctly on the right date.

Image

@phroi
Copy link
Contributor Author

phroi commented Jan 23, 2025

And about the date issue, I believe this is a mistake caused by time scaling as you can see on the x-axis.

Nope, not scaling as you can see, maybe different timezone so they get bucketed in different days?

I'm noticing how in your graph is correct, while in mines are not! Currently I'm in Vietnam and using Brave if it helps.

Image

Image

@poor-defined
Copy link

And about the date issue, I believe this is a mistake caused by time scaling as you can see on the x-axis.

Nope, not scaling as you can see, maybe different timezone so they get bucketed in different days?

I'm noticing how in your graph is correct, while in mines are not! Currently I'm in Vietnam and using Brave if it helps.

Image

Image

Oh, maybe, I will mark it first and we will correct it in asap, thank you bro :)

@phroi
Copy link
Contributor Author

phroi commented Jan 23, 2025

No worries!! If you plan on fixing it, once you have a fix feel free to ask me to double check it. Otherwise it's also okay to leave it like it is and just close the issue. Your call!

Phroi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants