Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change verify function to return Result<(), VerifyError> #166

Open
anhelinakruk opened this issue Nov 15, 2024 · 0 comments
Open

Change verify function to return Result<(), VerifyError> #166

anhelinakruk opened this issue Nov 15, 2024 · 0 comments

Comments

@anhelinakruk
Copy link

The verify function currently returns Result<bool, VerifyError>, which allows ambiguous cases like Ok(false). Consider changing the return type to Result<(), VerifyError> so:

  • Ok(()) indicates success.
  • Err(VerifyError) indicates failure.

This makes the function clearer and easier to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anhelinakruk