From 1cdd4f492b276defbde8baab87758e174e35d953 Mon Sep 17 00:00:00 2001 From: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com> Date: Sat, 2 Mar 2024 11:38:02 +0100 Subject: [PATCH 1/2] TASK: Revert temporary testing hack --- Configuration/Settings.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/Configuration/Settings.yaml b/Configuration/Settings.yaml index 4115099..be82519 100755 --- a/Configuration/Settings.yaml +++ b/Configuration/Settings.yaml @@ -25,12 +25,3 @@ Neos: catchUpHooks: 'Neos.RedirectHandler.NeosAdapter:DocumentUriPathProjectionHook': factoryObjectName: Neos\RedirectHandler\NeosAdapter\CatchUpHook\DocumentUriPathProjectionHookFactory - - Flow: - # TODO remove this temporary hack once neos is fixed. - object: - includeClasses: - "Neos.ContentRepository.TestSuite": - - "(*FAIL)" - "Neos.ContentRepositoryRegistry": - - "Neos\\\\ContentRepositoryRegistry\\\\(?!TestSuite\\\\Behavior\\\\CRRegistrySubjectProvider)" \ No newline at end of file From 2624b961d5e153012bda0e4527cfef69bbb08d54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anke=20H=C3=A4slich?= Date: Sat, 16 Mar 2024 10:44:13 +0100 Subject: [PATCH 2/2] BUGFIX: Fix constructor injection in `NodeRedirectService` Using `#[Flow\inject]` on a constructor parameter fails with `Attribute "Neos\Flow\Annotations\Inject" cannot target parameter (allowed targets: property)`. --- Classes/Service/NodeRedirectService.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Classes/Service/NodeRedirectService.php b/Classes/Service/NodeRedirectService.php index 10ae274..fa4a8e4 100644 --- a/Classes/Service/NodeRedirectService.php +++ b/Classes/Service/NodeRedirectService.php @@ -76,13 +76,9 @@ final class NodeRedirectService protected array $restrictByNodeType = []; public function __construct( - #[Flow\Inject] protected RedirectStorageInterface $redirectStorage, - #[Flow\Inject] protected PersistenceManagerInterface $persistenceManager, - #[Flow\Inject] protected ContentRepositoryRegistry $contentRepositoryRegistry, - #[Flow\Inject] protected SiteRepository $siteRepository, ) { }