From 335126ab08866f3eb0fdb3d5e72409609d363808 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Wed, 5 Feb 2025 09:27:09 +0100 Subject: [PATCH] BUGFIX: Render cke toolbar table dropdowns with data urls Resolves: #3897 We leverage our custom defined `.dataurl.svg` extension to let the build tooling use the data-url loader instead of inlining the svg contents. The dataurl loading was introduced with https://github.com/neos/neos-ui/pull/3836 --- .../src/EditorToolbar/icons/index.js | 6 +++--- .../icons/{table-column.svg => table-column.dataurl.svg} | 0 .../{table-merge-cell.svg => table-merge-cell.dataurl.svg} | 0 .../icons/{table-row.svg => table-row.dataurl.svg} | 0 4 files changed, 3 insertions(+), 3 deletions(-) rename packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/{table-column.svg => table-column.dataurl.svg} (100%) rename packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/{table-merge-cell.svg => table-merge-cell.dataurl.svg} (100%) rename packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/{table-row.svg => table-row.dataurl.svg} (100%) diff --git a/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/index.js b/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/index.js index 4145162666..8fbd7a357e 100644 --- a/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/index.js +++ b/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/index.js @@ -1,7 +1,7 @@ // These icons were taken (with color modification) from here: ckeditor5-table/theme/icons -import tableColumn from './table-column.svg'; -import tableRow from './table-row.svg'; -import tableMergeCells from './table-merge-cell.svg'; +import tableColumn from './table-column.dataurl.svg'; +import tableRow from './table-row.dataurl.svg'; +import tableMergeCells from './table-merge-cell.dataurl.svg'; const icons = { tableColumn, diff --git a/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-column.svg b/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-column.dataurl.svg similarity index 100% rename from packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-column.svg rename to packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-column.dataurl.svg diff --git a/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-merge-cell.svg b/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-merge-cell.dataurl.svg similarity index 100% rename from packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-merge-cell.svg rename to packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-merge-cell.dataurl.svg diff --git a/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-row.svg b/packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-row.dataurl.svg similarity index 100% rename from packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-row.svg rename to packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/icons/table-row.dataurl.svg