Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conflict resolution dialog instead of displaying raw workspace rebase error #3916

Open
mhsdesign opened this issue Feb 5, 2025 · 0 comments

Comments

@mhsdesign
Copy link
Member

The new conflict resolution is started during synchronising or publishing.
But there are further cases conflicts occur:

Resolution dialog for conflicts with base workspace on discard

Discarding a single page is only possible if there are no other conflicts with the base workspace in the workspace.

Steps to reproduce:

  1. Create a conflict on PageA (492c7c86) (delete it via another user and modify PageA in your workspace)
  2. Modify PageB
  3. Discard only changes on PageB

Now because the content repository cannot apply the remaining changes of PageA (that were not discarded) we get a conflict.
This is currently not handled in a pretty way:

Image

Solution could be:

Add an option to "discard selected changes AND drop conflicting changes" or "discard whole workspace"

Resolution dialog for conflicts of remaining changes in the workspace (publish and discard)

These two topics describe the problem of having an unpublishable change set:

neos/neos-development-collection#5364
neos/neos-development-collection#4997 (comment)

A simple way of creating such conflict during publish:

  1. Create a PageA (5d7c9911)
  2. within PageA create PageB
  3. Attempt to publish only PageB
Image
  1. Create a PageA (5d7c9911)
  2. within PageA create PageB
  3. Attempt to discard only PageA
Image

In #3893 we already attempted to offer a "Publish All" option that could look like this:

Image

But there are also a lot of other variants to be respected, and we should consider offering an option to widen the selection change-set to also publish other changes based on the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant