Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Deprecate and remove Twitter.Bootstrap as core dependency #5408

Open
1 task done
Sebobo opened this issue Dec 19, 2024 · 3 comments · Fixed by #5409
Open
1 task done

TASK: Deprecate and remove Twitter.Bootstrap as core dependency #5408

Sebobo opened this issue Dec 19, 2024 · 3 comments · Fixed by #5409
Assignees
@Sebobo
Labels
Feature

Comments

@Sebobo
Copy link
Member

Sebobo commented Dec 19, 2024

Is there an existing issue for this topic?

  • I have searched the existing issues

Description

The only place that references it is the Media.Browser which requires the JS library

Possible Solution

Move the required js file into the media browser and remove the dependency.
@Sebobo Sebobo added the Feature label Dec 19, 2024
@Sebobo Sebobo self-assigned this Dec 19, 2024
Sebobo added a commit that referenced this issue Dec 19, 2024
@Sebobo
!!! FEATURE: Drop twitter bootstrap dependency
92ba6cc 
We only used it in one place and it’s basically not maintained anymore.
With this change the bootstrap library that is required for the media browser is moved to the media browser and therefore no other dependency is left.

This might be breaking for projects that use the bootstrap viewhelper or library and didn’t add they own dependency.

Resolves: #5408
@Sebobo Sebobo mentioned this issue Dec 19, 2024
Merged
@mhsdesign
Copy link
Member

can we also archive the non maintained bootstrap package then?

@mhsdesign mhsdesign reopened this Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Done ✅ to Todo in Neos 9.0 Release Board Dec 20, 2024
@mhsdesign mhsdesign changed the title FEATURE: Drop Twitter.Bootstrap as core dependency TASK: Deprecate and remove Twitter.Bootstrap as core dependency Dec 20, 2024
@Sebobo
Copy link
Member Author

Sebobo commented Dec 20, 2024

@mhsdesign why did you reopen the issue?

We can archive https://github.com/neos/twitter-bootstrap I guess. I'm not aware of other dependencies

@mhsdesign
Copy link
Member

why did you reopen the issue?

i thought to have it as marker for the discussion, i thought a new issue would cause too much confusion and lack of overview :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
Feature
Projects
Neos 9.0 Release Board
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

!!! FEATURE: Drop twitter bootstrap dependency neos/neos-development-collection
2 participants
@Sebobo @mhsdesign