Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Why we use "Id" instead of "Identifier" (for Neos 9) #5024

Closed
mhsdesign opened this issue May 1, 2024 · 0 comments
Closed

FYI: Why we use "Id" instead of "Identifier" (for Neos 9) #5024

mhsdesign opened this issue May 1, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

This is not a real issue but i think it should have been in 2022 ^^
This is just to document the discussions and implementation that refactored Node::nodeAggregateIdentifier to Node::nodeAggregateId

Initially the idea was first discussed in team meetings and later put on discuss: https://discuss.neos.io/t/rfc-use-id-instead-of-identifier-for-neos-9/6001
After general approval the change was committed 5f80a56 (directly on 9.0 as this was heavy under development with several changes daily to get a working version after the merge of the escr into Neos)

Later this change was discussed and criticised again in slack and a related pr:

One point that stood out was that the rule to consistently use abbreviations originated from when there was not such good code autocompletion and linting in php. Modern day IDE's like phpstorm make it a breeze to work with either of them as you just check whats available. But this is not true for Fusion and EEL. Here time dials back and many user use the try and error approach. And here it is generally easier to work with if you have a few rules in your head which you know they apply like: No abbreviations.

We are currently conceptualising a translation layer in eel to restore the node.identifier syntax for ease of use: #5022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant